gh-130425: Add "Did you mean [...]" suggestions for del obj.attr
#136588
+118
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Jul 12, 2025
del obj.attr
picnixz
reviewed
Jul 12, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-02-22-01-23-23.gh-issue-130425.x5SNQ8.rst
Show resolved
Hide resolved
picnixz
reviewed
Jul 12, 2025
Doc/whatsnew/3.15.rst
Outdated
| @@ -175,6 +175,20 @@ Other language changes | |||
| * Several error messages incorrectly using the term "argument" have been corrected. | |||
| (Contributed by Stan Ulbrych in :gh:`133382`.) | |||
|
|
|||
| * The interpreter now provides helpful suggestions when :func:`delattr` fails due to a missing attribute. When an attribute name that closely resembles an existing attribute is used, the interpreter will suggest the correct attribute name in the error message. For example: | |||
There was a problem hiding this comment.
Can you wrap the text under 80 characters per line?
Doc/whatsnew/3.15.rst
Outdated
| ... pass | ||
| >>> a = A() | ||
| >>> a.abcde = 1 | ||
| >>> del a.abcdf |
There was a problem hiding this comment.
I think you need # doctest: +ELLIPSIS
Doc/whatsnew/3.15.rst
Outdated
| ... | ||
| AttributeError: 'A' object has no attribute 'abcdf'. Did you mean: 'abcde'? | ||
|
|
||
| (Contributed by [sobolevn] and Pranjal Prajapati in :gh:`136588`.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the earlier PR #130799 (now closed) and carries over that set of commits, preserving original authorship and history. An extra commit has been included to address a linting issue that was present in the previous version.
Issue: #130425