Skip to content

gh-55531: Implement normalize_encoding in C #136643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-55531: Implement normalize_encoding in C #136643

wants to merge 6 commits into from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Jul 14, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 14, 2025
Open
StanFromIreland
StanFromIreland commented Jul 14, 2025
View reviewed changes
picnixz
picnixz reviewed Jul 14, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's a draft but here are already some comments that you can dismiss if you're working on them.

picnixz
picnixz reviewed Jul 14, 2025
View reviewed changes
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Jul 14, 2025 •
edited
Loading

I have cleaned up the changes and ensure the behavior remains the same, however there are still a few points I need input from @malemburg
(And as Benedikt said, should be their own issue)

  • This function is documented as taking strings, but during the 2->3 conversion and undocumented, and untested change was made which allowed it to accept bytes. I have kept it this way (in Python, to make removal simpler), though I think this should either be documented and tested, or removed.
  • The function has been documented as ascii only, and for bytes, it is. However, for strings, it has not been enforced with an error. What should we do?

@StanFromIreland StanFromIreland marked this pull request as ready for review July 14, 2025 12:54
@StanFromIreland StanFromIreland requested a review from picnixz July 14, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@malemburg malemburg Awaiting requested review from malemburg

@picnixz picnixz Awaiting requested review from picnixz

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanFromIreland @picnixz
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy