bpo-39533: Use statx on more recent Linux to expose st_flags and st_btime on all platforms
#19125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1c474bf to
bd158bb
Compare
SebAlbert
reviewed
Sep 5, 2022
bd158bb to
8a8bab2
Compare
|
All commit authors signed the Contributor License Agreement. |
667ece4 to
4d1edcc
Compare
On BSD/macOS this uses the value of `st_birthtime` (which remains for compatibity reasons), on Windows it duplicates the value of `st_ctime`. A Linux implementation is added in subsequent commits.
It cannot be enabled by default because this implementation does not have any fallback to plain stat for older kernels and Linux 4.11 is still fairly recent. The configure checks also ensure that the C library expose the proper stub functions (glibc 2.28+ only).
…D UF_* equivalent as defined by FreeBSD
4d1edcc to
9aae324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing tests, but I'd appreciate feedback on the changes themselves in the meantime. Also ideas for properly testing
btimewould be appreciated.#83714