-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-84530: Introduce a new type for namespace packages #19917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a news entry.
May I suggest using the
I think the return would look something like the one done for the if spec.loader is None and spec.submodule_search_locations:
return None, os.path.dirname(str(spec.submodule_search_locations)), ("", "", _PKG_DIRECTORY) |
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
While this fix appears to solve the top-level namespace package, it seems to fail on solving the nested namespace packages, i.e. |
This PR fixes
modulefinder.py
's module-loader to handle namespace packages differently than regular packages, and in doing so introduces a separate type for namespace packages.https://bugs.python.org/issue40350