Skip to content

bpo-34001: Change handling of SSL protocol bounds with LibreSSL #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

bpo-34001: Change handling of SSL protocol bounds with LibreSSL #8055

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4254483
bpo-34001: add checks for protocol boundary ranges
Jul 2, 2018
8352fd3
bpo-34001: add checks for LibreSSL
Jul 2, 2018
77d24d8
bpo-34001: fix tests
Jul 2, 2018
2a09611
bpo-34001: add test for protocol boundary restrictions
Jul 3, 2018
f415a39
bpo-34001: add blurb
Jul 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-34001: fix tests 
This commit fixes tests by removing invalid range settings.
  • Loading branch information
Alan Huang authored and Alan Huang committed Jul 3, 2018
commit 77d24d830fa4976998ac41b253d06654fae3ed5b
3 changes: 2 additions & 1 deletion Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,7 @@ def test_min_max_version(self):
ctx.maximum_version,
{ssl.TLSVersion.TLSv1, ssl.TLSVersion.SSLv3}
)
ctx.maximum_version = ssl.TLSVersion.MAXIMUM_SUPPORTED

ctx.minimum_version = ssl.TLSVersion.MAXIMUM_SUPPORTED
self.assertIn(
Expand Down Expand Up @@ -3572,8 +3573,8 @@ def test_min_max_version(self):
self.assertEqual(s.version(), 'TLSv1.1')

# client 1.0, server 1.2 (mismatch)
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
server_context.maximum_version = ssl.TLSVersion.TLSv1_2
server_context.minimum_version = ssl.TLSVersion.TLSv1_2
client_context.minimum_version = ssl.TLSVersion.TLSv1
client_context.maximum_version = ssl.TLSVersion.TLSv1
with ThreadedEchoServer(context=server_context) as server:
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy