[mypyc] Add primitives for isinstance of built-in types #19435
Conversation
| name="builtins.isinstance", | ||
| arg_types=[object_rprimitive], | ||
| return_type=bit_rprimitive, | ||
| c_function_name="PyFloat_Check", |
There was a problem hiding this comment.
This should use CPyFloat_Check, since we always implicitly accept integers as compatible with float.
|
|
||
| [case testIsInstance] | ||
| def test_built_in() -> None: | ||
| assert isinstance(True, bool) |
There was a problem hiding this comment.
Optional nit: It's slightly better to use e.g. something like b: Any = True followed by isinstance(b, bool), since a future version of mypyc might otherwise optimize the whole check away (here and elsewhere). It's not a big deal, but in the future it's often better to use expressions like these instead of bool/int/str/bytes literals in run tests:
int() + 1instead of1str() + "x"instead of"x"
Container types are generally fine, since we are less likely to optimize them away. It's a loose convention that values with Any types and no-argument constructors for primitives such as int() are not optimized much.
| @@ -64,6 +64,24 @@ | |||
| error_kind=ERR_MAGIC, | |||
| ) | |||
|
|
|||
| # isinstance(obj, set) | |||
There was a problem hiding this comment.
Remove or be more explicit. Code as comment looks like accidental committed leftovers from a debugging session.
Follow-up to #19416 adding primitives for
isinstance(obj, type)where type is built-in.