[mypyc] Add SetElement op for initializing struct values #19437
Merged
+137
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add Undef value type that can currently only used as the operand for SetElement to signify that we are creating a new value instead of modifying an existing value.
peturingi
reviewed
Jul 14, 2025
mypyc/ir/ops.py
Outdated
| # r1 now has new struct value with two fields set | ||
|
|
||
| Warning: The generated code can use an arbitrary runtime values for | ||
| this (likely not explicitly initialized). |
peturingi
reviewed
Jul 14, 2025
| def __init__(self, src: Value, field: str, item: Value, line: int = -1) -> None: | ||
| super().__init__(line) | ||
| assert isinstance(src.type, RStruct), src.type | ||
| self.type = src.type |
There was a problem hiding this comment.
Irrelevant as it won't play nice with
def visit_set_element(self, op: SetElement) -> None:
op.src = self.fix_op(op.src)
peturingi
approved these changes
Jul 14, 2025
p-sawicki
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add Undef value type that can currently only used as the
operand for SetElement to signify that we are creating a new
value instead of modifying an existing value.
A new struct value can be created by starting with Undef and
setting each element sequentially. Each operation produces a
new struct value, but the temporaries will be optimized away
in the later passes (currently by the C compiler, but we could
do something more clever here in the future).
This is needed to support packed arrays, which are represented
as structs. I extracted this from my packed array branch, and
it's currently unused outside tests.