Skip to content

Remove expired deprecation of using scipy matrix #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

Remove expired deprecation of using scipy matrix #393

merged 3 commits into from
Feb 21, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Feb 21, 2023

Note that we now maintain a list of active deprecations on our wiki:

https://github.com/python-graphblas/python-graphblas/wiki/Active-deprecations

@eriknw eriknw added the deprecation Something is being removed label Feb 21, 2023
@coveralls
Copy link

coveralls commented Feb 21, 2023 •
edited
Loading

Coverage Status

Coverage: 99.424% (-0.08%) from 99.505% when pulling 9c9df06 on eriknw:remove_scipy_matrix into b7e9485 on python-graphblas:main.

@eriknw
Copy link
Member Author

eriknw commented Feb 21, 2023

Oh, interesting test failures (randomized testing ftw?!). This is using python-suitesparse-graphblas from upstream, which supports complex on Windows.

It looks like asin(4 + 0j) gives the wrong results on Windows in SuiteSparse:GraphBLAS. This is a known limitation. From SuiteSparse:GraphBLAS documentation:

  1. On Windows, the casin, casinf, casinh, and casinhf functions provided by Microsoft do not return the correct imaginary part. As a result, GxB_ASIN_FC32, GxB_ASIN_FC64 GxB_ASINH_FC32, and GxB_ASINH_FC64 do not work properly on Windows. This affects the GrB/asin, GrB/acsc, GrB/asinh, and GrB/acsch, functions in the MATLAB interface. See the MATLAB tests bypassed in gbtest76.m for details, in the GraphBLAS/GraphBLAS/test folder.

So, we'll need to update tests to ignore these on Windows.

I'm not sure what's up with the error with ldexp. Need to print more info.

@eriknw
Copy link
Member Author

eriknw commented Feb 21, 2023

Heh, so we may have more places where we use if not _supports_complex instead of if is_win. If so, we'll fine them eventually.

eriknw
eriknw commented Feb 21, 2023
View reviewed changes
graphblas/tests/test_numpyops.py
Comment on lines +71 to +72
blocklist["FC64"].update({"asin", "asinh"})
blocklist["FC32"] = {"asin", "asinh"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we strictly need to exclude asinh given the input arguments we use, but asinh was called out in the documentation for not working.

@eriknw
Copy link
Member Author

eriknw commented Feb 21, 2023

I'm going to go ahead and merge this since it contains a fix, and I don't think the removed deprecations are particularly significant.

@eriknw eriknw merged commit 096d374 into python-graphblas:main Feb 21, 2023
@eriknw eriknw mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deprecation Something is being removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriknw @coveralls
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy