Skip to content

Remove deprecated gb.core.agg #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .flake8
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,5 @@ extend-ignore =
per-file-ignores =
scripts/create_pickle.py:F403,F405,
graphblas/tests/*.py:T201,
graphblas/core/agg.py:F401,F403,
graphblas/core/ss/matrix.py:SIM113,
graphblas/**/__init__.py:F401,
2 changes: 1 addition & 1 deletion .github/workflows/test_and_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ jobs:
echo "from graphblas.agg import count" > script.py
coverage run -a script.py
echo "from graphblas import agg" > script.py # Does this still cover?
echo "from graphblas.core import agg" >> script.py
echo "from graphblas.core.operator import agg" >> script.py
coverage run -a script.py
# Tests lazy loading of lib, ffi, and NULL in gb.core
echo "from graphblas.core import base" > script.py
Expand Down
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ repos:
# We can probably remove `isort` if we come to trust `ruff --fix`,
# but we'll need to figure out the configuration to do this in `ruff`
- repo: https://github.com/pycqa/isort
rev: 5.13.1
rev: 5.13.2
hooks:
- id: isort
# Let's keep `pyupgrade` even though `ruff --fix` probably does most of it
Expand All @@ -66,7 +66,7 @@ repos:
- id: black
- id: black-jupyter
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.7
rev: v0.1.8
hooks:
- id: ruff
args: [--fix-only, --show-fixes]
Expand Down Expand Up @@ -94,7 +94,7 @@ repos:
additional_dependencies: [tomli]
files: ^(graphblas|docs)/
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.1.7
rev: v0.1.8
hooks:
- id: ruff
- repo: https://github.com/sphinx-contrib/sphinx-lint
Expand Down
2 changes: 1 addition & 1 deletion graphblas/agg/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
# - bxnor monoid: even bits
# - bnor monoid: odd bits
"""
# All items are dynamically added by classes in core/agg.py
# All items are dynamically added by classes in core/operator/agg.py
# This module acts as a container of Aggregator instances
_deprecated = {}

Expand Down
17 changes: 0 additions & 17 deletions graphblas/core/agg.py

This file was deleted.

2 changes: 0 additions & 2 deletions graphblas/tests/test_op.py
Original file line number Diff line number Diff line change
Expand Up @@ -1450,8 +1450,6 @@ def test_deprecated():
gb.op.secondj
with pytest.warns(DeprecationWarning, match="please use"):
gb.agg.argmin
with pytest.warns(DeprecationWarning, match="please use"):
import graphblas.core.agg # noqa: F401


@pytest.mark.slow
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,6 @@ ignore = [
]

[tool.ruff.per-file-ignores]
"graphblas/core/agg.py" = ["F401", "F403"] # Deprecated
"graphblas/core/operator/base.py" = ["S102"] # exec is used for UDF
"graphblas/core/ss/matrix.py" = ["NPY002"] # numba doesn't support rng generator yet
"graphblas/core/ss/vector.py" = ["NPY002"] # numba doesn't support rng generator yet
Expand Down
2 changes: 1 addition & 1 deletion scripts/check_versions.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ conda search 'numpy[channel=conda-forge]>=1.26.2'
conda search 'pandas[channel=conda-forge]>=2.1.4'
conda search 'scipy[channel=conda-forge]>=1.11.4'
conda search 'networkx[channel=conda-forge]>=3.2.1'
conda search 'awkward[channel=conda-forge]>=2.5.0'
conda search 'awkward[channel=conda-forge]>=2.5.1'
conda search 'sparse[channel=conda-forge]>=0.14.0'
conda search 'fast_matrix_market[channel=conda-forge]>=1.7.5'
conda search 'numba[channel=conda-forge]>=0.58.1'
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy