-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Open
Labels
module: mpsRelated to Apple Metal Performance Shaders frameworkRelated to Apple Metal Performance Shaders frameworkmodule: regressionIt used to work, and now it doesn'tIt used to work, and now it doesn'ttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
#128393 caused numerous performance/correctness regressions for the ops that had a special codepath for channels last, see
- MPS Regression when rendering LTXVideo (after pytorch2.4.1) #141471
- View size is not compatible, using Conv1d on channels-last Tensor, reported during backward on mps. #140902
- Nightly introduced bug for GGUF in comfy? #137800
- RuntimeError when running backward on MPS: "view size is not compatible" with self-attention block #142344
Would be nice to have a better testing for those cases
Versions
2.5.0, 2.5.1, nightly
cc @ezyang @gchanan @zou3519 @kadeng @msaroufim @kulinseth @albanD @DenisVieriu97 @jhavukainen
Metadata
Metadata
Assignees
Labels
module: mpsRelated to Apple Metal Performance Shaders frameworkRelated to Apple Metal Performance Shaders frameworkmodule: regressionIt used to work, and now it doesn'tIt used to work, and now it doesn'ttriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module