[MPS] Fix regression in con-contig bitwise ops #146085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146085
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 36 PendingAs of commit ae6c1e5 with merge base 08ff11e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
dcci
approved these changes
Jan 30, 2025
dcci
approved these changes
Jan 30, 2025
|
@pytorchbot merge -f "Lint + MPS are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Feb 6, 2025
Caused by pytorch#128393 that change semantic of `needsGather`, which resulted in silent correctness errors on MacOS-15+ if output tensor is non-contiguous Fixes pytorch#145203 Pull Request resolved: pytorch#146085 Approved by: https://github.com/dcci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #128393 that change semantic of
needsGather, which resulted in silent correctness errors on MacOS-15+ if output tensor is non-contiguousFixes #145203