[BE] follow autoformating and linter #151507

XilunWu · 2025-04-17T02:37:22Z

Stack from ghstack (oldest at bottom):

-> [BE] follow autoformating and linter #151507

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

[ghstack-poisoned]

pytorch-bot · 2025-04-17T02:37:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151507

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 86 Pending

As of commit aba47a8 with merge base 78953ee ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Skylion007

Can we make sure this file is in the relevant include list for lintrunner?

XilunWu · 2025-04-17T16:33:50Z

@Skylion007 good point! Do you know where I can find information about it?

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]

…rt to DTensor in FakeTensorMode" Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #151497 * #151507 * __->__ #151495 ## Introduction `flex_attention`'s FakeTensor propagation `flex_attention_fake_impl` [permutes](https://github.com/pytorch/pytorch/blob/fb6ac2f16132f7953711ce6924bc2ee4a033228c/torch/_higher_order_ops/flex_attention.py#L459) the stride of `out` (the attention score) based on `query`'s stride. To enable `flex_attention` call on DTensor, this requires us add `as_strided` support on DTensor in `FakeTensorMode`. ## Limited Support Due to the complexity of supporting actual `as_strided` on DTensor, I choose to only enable a limited subset: 1. `as_strided` only works correctly in `FakeTensorMode` i.e. shape and strided propagation. 2. `as_strided` is only allowed in case where `size == input.shape` because this PR specifically unblocks the use case of `flex_attention_fake_impl`. 3. `as_strided` requires `storage_offset=None` because the other case is not defined in DTensor. ## Test `pytest test/distributed/tensor/test_view_ops.py -s -k test_as_strided` cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k tianyu-l [ghstack-poisoned]

… FakeTensorMode" Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #151497 * #151507 * __->__ #151495 ## Introduction `flex_attention`'s FakeTensor propagation `flex_attention_fake_impl` [permutes](https://github.com/pytorch/pytorch/blob/fb6ac2f16132f7953711ce6924bc2ee4a033228c/torch/_higher_order_ops/flex_attention.py#L459) the stride of `out` (the attention score) based on `query`'s stride. To enable `flex_attention` call on DTensor, this requires us add `as_strided` support on DTensor in `FakeTensorMode`. ## Limited Support Due to the complexity of supporting actual `as_strided` on DTensor, I choose to only enable a limited subset: 1. `as_strided` only works correctly in `FakeTensorMode` i.e. shape and strided propagation. 2. `as_strided` is only allowed in case where `size == input.shape` because this PR specifically unblocks the use case of `flex_attention_fake_impl`. 3. `as_strided` requires `storage_offset=None` because the other case is not defined in DTensor. ## Test `pytest test/distributed/tensor/test_view_ops.py -s -k test_as_strided` cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k tianyu-l [ghstack-poisoned]

cyyever · 2025-04-20T11:58:43Z

check .lintrunner.toml

cyyever · 2025-04-22T06:28:29Z

@pytorchmergebot merge -i

pytorchmergebot · 2025-04-22T06:30:30Z

Merge started

Your change will be merged while ignoring the following 4 checks: inductor / unit-test / linux-jammy-cpu-py3.12-gcc11-inductor-halide / test (inductor-halide, 1, 1, linux.12xlarge), inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / cuda12.6-py3.10-gcc9-sm86 / test (inductor, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / cuda12.6-py3.12-gcc9-sm86 / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-04-22T09:03:28Z

Merge failed

Reason: PR #151495 has not been reviewed yet

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]

…rt to DTensor in FakeTensorMode" Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #151497 * #151507 * __->__ #151495 ## Introduction `flex_attention`'s FakeTensor propagation `flex_attention_fake_impl` [permutes](https://github.com/pytorch/pytorch/blob/fb6ac2f16132f7953711ce6924bc2ee4a033228c/torch/_higher_order_ops/flex_attention.py#L459) the stride of `out` (the attention score) based on `query`'s stride. To enable `flex_attention` call on DTensor, this requires us add `as_strided` support on DTensor in `FakeTensorMode`. ## Limited Support Due to the complexity of supporting actual `as_strided` on DTensor, I choose to only enable a limited subset: 1. `as_strided` only works correctly in `FakeTensorMode` i.e. shape and strided propagation. 2. `as_strided` is only allowed in case where `size == input.shape` because this PR specifically unblocks the use case of `flex_attention_fake_impl`. 3. `as_strided` requires `storage_offset=None` because the other case is not defined in DTensor. ## Test `pytest test/distributed/tensor/test_view_ops.py -s -k test_as_strided` cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k tianyu-l [ghstack-poisoned]

… FakeTensorMode" Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom): * #151497 * #151507 * __->__ #151495 ## Introduction `flex_attention`'s FakeTensor propagation `flex_attention_fake_impl` [permutes](https://github.com/pytorch/pytorch/blob/fb6ac2f16132f7953711ce6924bc2ee4a033228c/torch/_higher_order_ops/flex_attention.py#L459) the stride of `out` (the attention score) based on `query`'s stride. To enable `flex_attention` call on DTensor, this requires us add `as_strided` support on DTensor in `FakeTensorMode`. ## Limited Support Due to the complexity of supporting actual `as_strided` on DTensor, I choose to only enable a limited subset: 1. `as_strided` only works correctly in `FakeTensorMode` i.e. shape and strided propagation. 2. `as_strided` is only allowed in case where `size == input.shape` because this PR specifically unblocks the use case of `flex_attention_fake_impl`. 3. `as_strided` requires `storage_offset=None` because the other case is not defined in DTensor. ## Test `pytest test/distributed/tensor/test_view_ops.py -s -k test_as_strided` cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k tianyu-l [ghstack-poisoned]

ghstack-source-id: f757813 Pull Request resolved: pytorch/pytorch#151507

[ghstack-poisoned]

ghstack-source-id: 2083a07 Pull Request resolved: #151507

XilunWu · 2025-04-24T06:29:18Z

@pytorchbot merge

pytorchmergebot · 2025-04-24T06:31:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

cyyever · 2025-04-24T07:34:38Z

@pytorchbot merge -f "Linters have passed"

pytorchmergebot · 2025-04-24T07:34:56Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2025-04-24T07:36:51Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: pytorch#151507 Approved by: https://github.com/Skylion007

ghstack-source-id: f757813 Pull Request resolved: pytorch/pytorch#151507

[BE] follow autoformating and linter

6454f31

[ghstack-poisoned]

XilunWu mentioned this pull request Apr 17, 2025

[cp] dispatch flex_attention to CP impl in TorchDispatchMode #151497

Open

pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Apr 17, 2025

XilunWu mentioned this pull request Apr 17, 2025

[dtensor][view_op] add as_strided op support to DTensor in FakeTensorMode #151495

Open

XilunWu requested review from tianyu-l, Skylion007 and wz337 April 17, 2025 02:39

XilunWu mentioned this pull request Apr 17, 2025

[BE] follow autoformating and linter #151496

Closed

XilunWu added the topic: not user facing topic category label Apr 17, 2025

Skylion007 approved these changes Apr 17, 2025

View reviewed changes

Update on "[BE] follow autoformating and linter"

3f2f720

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]

XilunWu mentioned this pull request Apr 18, 2025

DTensor HOP call in TorchDispatchMode #151685

Closed

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 22, 2025

pytorchmergebot added the merging label Apr 22, 2025

pytorchmergebot removed the merging label Apr 22, 2025

Update on "[BE] follow autoformating and linter"

316337b

cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k [ghstack-poisoned]

XilunWu mentioned this pull request Apr 22, 2025

[cp] dispatch flex_attention on DTensor to cp implementation #151900

Draft

This was referenced Apr 22, 2025

[cp] cast tensor to DTensor for flex_attention #151902

Closed

[cp] Context Parallel: dispatch flex_attention to CP impl in TorchDispatchMode #151903

Closed

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request Apr 22, 2025

[BE] follow autoformating and linter

fd594de

ghstack-source-id: f757813 Pull Request resolved: pytorch/pytorch#151507

Update

aba47a8

[ghstack-poisoned]

XilunWu added a commit that referenced this pull request Apr 24, 2025

[BE] follow autoformating and linter

5d45ded

ghstack-source-id: 2083a07 Pull Request resolved: #151507

pytorchmergebot added the merging label Apr 24, 2025

pytorchmergebot closed this in 5e320ee Apr 24, 2025

pytorchmergebot added Merged and removed merging labels Apr 24, 2025

rec pushed a commit to rec/pytorch that referenced this pull request Apr 25, 2025

[BE] follow autoformating and linter (pytorch#151507)

f046df2

Pull Request resolved: pytorch#151507 Approved by: https://github.com/Skylion007

github-actions bot deleted the gh/XilunWu/134/head branch June 12, 2025 02:22

superiwan pushed a commit to superiwan/pytorch that referenced this pull request Jul 14, 2025

[BE] follow autoformating and linter

0ec95a6

ghstack-source-id: f757813 Pull Request resolved: pytorch/pytorch#151507

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BE] follow autoformating and linter #151507

[BE] follow autoformating and linter #151507

Uh oh!

XilunWu commented Apr 17, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Apr 17, 2025 •

edited

Loading

Uh oh!

Skylion007 left a comment

Uh oh!

XilunWu commented Apr 17, 2025

Uh oh!

cyyever commented Apr 20, 2025

Uh oh!

cyyever commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Uh oh!

XilunWu commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Uh oh!

cyyever commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

[BE] follow autoformating and linter #151507

[BE] follow autoformating and linter #151507

Uh oh!

Conversation

XilunWu commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151507

⏳ No Failures, 86 Pending

Uh oh!

Skylion007 left a comment

Choose a reason for hiding this comment

Uh oh!

XilunWu commented Apr 17, 2025

Uh oh!

cyyever commented Apr 20, 2025

Uh oh!

cyyever commented Apr 22, 2025

Uh oh!

pytorchmergebot commented Apr 22, 2025

Merge started

Uh oh!

pytorchmergebot commented Apr 22, 2025

Merge failed

Uh oh!

XilunWu commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Merge started

Uh oh!

cyyever commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Uh oh!

pytorchmergebot commented Apr 24, 2025

Merge started

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

XilunWu commented Apr 17, 2025 •

edited

Loading

pytorch-bot bot commented Apr 17, 2025 •

edited

Loading