🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154801

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f302434 with merge base f88d7a7 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@Skylion007 your PR has been successfully reverted.

@aorenste Looks like this uncovered more typing errors inside of Meta. Not sure if the input args need to be more flexible or if the private type alias was actually used somewhere else or what, but if you could help land, that would be super helpful.

Looking at torch_tune, it looks like the alias is actually used...

@nathan-az If the internal issue is just the internal typing, feel free to revert that change and keep the decorator typing.

I can help - but I have to wait for our internal tooling to be fixed. Without that there's no way to run all the tests that could have fallout - so it lands and then tests start failing.

@pytorchbot rebase

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/154801/head returned non-zero exit code 1

warning: skipped previously applied commit da780b97500
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config set advice.skippedCherryPicks false"
Rebasing (1/1)
Auto-merging torch/nn/utils/clip_grad.py
CONFLICT (content): Merge conflict in torch/nn/utils/clip_grad.py
error: could not apply e17cc8767c6... Revert private TypeAlias rename
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply e17cc8767c6... Revert private TypeAlias rename

Raised by https://github.com/pytorch/pytorch/actions/runs/15519092514

@pytorchbot rebase

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/154801/head returned non-zero exit code 1

warning: skipped previously applied commit da780b97500
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config set advice.skippedCherryPicks false"
Rebasing (1/1)
Auto-merging torch/nn/utils/clip_grad.py
CONFLICT (content): Merge conflict in torch/nn/utils/clip_grad.py
error: could not apply e17cc8767c6... Revert private TypeAlias rename
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply e17cc8767c6... Revert private TypeAlias rename

Raised by https://github.com/pytorch/pytorch/actions/runs/16126456689

@aorenste Rebased

@aorenste has imported this pull request. If you are a Meta employee, you can view this in D77943246.

Imported internally and it passes all tests.
I also manually ran it on a bunch of internal typechecking tests that I know failed on other typechecking diffs and it passed there (our internal "full check" tool is still not working yet :( ).
Looking at the original land attempt it actually looked fine to me - I suspect it actually got caught up paired with another PR that did actually have issues at the same time.
@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team