[struct] Add struct.pack and struct.unpack polyfills
#156977
Open
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156977
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 4 Unrelated FailuresAs of commit 20d6316 with merge base dea4864 ( CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 26, 2025
XuehaiPan
approved these changes
Jul 9, 2025
jansel
approved these changes
Jul 9, 2025
XuehaiPan
reviewed
Jul 10, 2025
XuehaiPan
reviewed
Jul 10, 2025
torch/_dynamo/polyfills/struct.py
Outdated
|
|
||
|
|
||
| @substitute_in_graph(struct.pack, can_constant_fold_through=True) # type: ignore[arg-type] | ||
| def pack(fmt: Union[bytes, str], /, *v: Any) -> bytes: |
There was a problem hiding this comment.
Suggested change
| def pack(fmt: Union[bytes, str], /, *v: Any) -> bytes: | |
| def pack(fmt: str | bytes, /, *v: Any) -> bytes: |
XuehaiPan
reviewed
Jul 10, 2025
torch/_dynamo/polyfills/struct.py
Outdated
|
|
||
|
|
||
| @substitute_in_graph(struct.unpack, can_constant_fold_through=True) # type: ignore[arg-type] | ||
| def unpack(format: Union[bytes, str], buffer: bytes) -> tuple[Any, ...]: |
There was a problem hiding this comment.
Suggested change
| def unpack(format: Union[bytes, str], buffer: bytes) -> tuple[Any, ...]: | |
| def unpack(format: str | bytes, buffer: collections.abc.Buffer, /) -> tuple[Any, ...]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
struct.packandstruct.unpackpolyfills #156977float.fromhex#156976cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames