Skip to content

[AOTI] add Windows file ext to package loader. #158578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[AOTI] add Windows file ext to package loader. #158578

wants to merge 5 commits into from
+18 −2

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Jul 17, 2025 •
edited
Loading

@xuhancn xuhancn added the topic: not user facing topic category label Jul 17, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158578

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 59a9892 with merge base 35df895 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2025
@xuhancn xuhancn added module: windows Windows support for PyTorch intel This tag is for PR from Intel labels Jul 17, 2025
@xuhancn xuhancn marked this pull request as ready for review July 17, 2025 18:31
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 17, 2025
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 18, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / cuda12.8-py3.10-gcc9-sm75 / test (pr_time_benchmarks, 1, 1, linux.g4dn.metal.nvidia.gpu, unstable), inductor / cuda12.8-py3.10-gcc9-sm86 / test (inductor_torchbench, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch rebase origin/main returned non-zero exit code 1

Rebasing (1/1)
Auto-merging torch/csrc/inductor/aoti_package/model_package_loader.cpp
CONFLICT (content): Merge conflict in torch/csrc/inductor/aoti_package/model_package_loader.cpp
error: could not apply 0548cda76b5... [AOTI] add Windows file ext to package loader. (#158578)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 0548cda76b5... # [AOTI] add Windows file ext to package loader. (#158578)
Details for Dev Infra team Raised by workflow job

@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 18, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/158578/head returned non-zero exit code 1

Rebasing (1/22)
Rebasing (2/22)
Rebasing (3/22)
Rebasing (4/22)
Rebasing (5/22)
Rebasing (6/22)
Rebasing (7/22)
Rebasing (8/22)
Rebasing (9/22)
Rebasing (10/22)
Rebasing (11/22)
Rebasing (12/22)
Rebasing (13/22)
Rebasing (14/22)
Rebasing (15/22)
Rebasing (16/22)
Rebasing (17/22)
Rebasing (18/22)
Rebasing (19/22)
Rebasing (20/22)
Rebasing (21/22)
Auto-merging torch/csrc/inductor/aoti_package/model_package_loader.cpp
CONFLICT (content): Merge conflict in torch/csrc/inductor/aoti_package/model_package_loader.cpp
error: could not apply 35df895d056... [AOTI] package loader normalize path separator (#158630)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Could not apply 35df895d056... # [AOTI] package loader normalize path separator (#158630)

Raised by https://github.com/pytorch/pytorch/actions/runs/16375131167

@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 18, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xuhancn xuhancn deleted the xu_add_file_ext_for_Windows branch July 18, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelayi angelayi angelayi approved these changes

@desertfire desertfire Awaiting requested review from desertfire

@jansel jansel Awaiting requested review from jansel

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel Merged module: windows Windows support for PyTorch open source release notes: inductor (aoti) topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xuhancn @pytorchmergebot @angelayi @pytorchbot @janeyx99
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy