Skip to content

[inductor] Make times and repeat parameters command line args #158590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[inductor] Make times and repeat parameters command line args #158590

wants to merge 1 commit into from
+15 −2

Conversation

A-Kokolis
Copy link
Contributor

@A-Kokolis A-Kokolis commented Jul 17, 2025 •
edited by pytorch-bot bot
Loading

Summary: Small change to make the times and repeat variables controllable as command line args.

Test Plan:
Execute:

buck2 run <run params> <path>:inductor_benchmark -- --times=1 --repeat=1

Only runs once, and without passing the args it runs with default values of 10.

Rollback Plan:

Reviewed By: malfet

Differential Revision: D78458680

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 17, 2025

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @A-Kokolis, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 17, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: A-Kokolis / name: Apostolos Kokolis (d640598)

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158590

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit d640598 with merge base 8dcebaa (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78458680

@A-Kokolis A-Kokolis requested a review from malfet July 17, 2025 19:31
A-Kokolis added a commit to A-Kokolis/pytorch that referenced this pull request Jul 17, 2025
@A-Kokolis @facebook-github-bot
[inductor] Make times and repeat parameters command line args (pytorc…
a5feba9 
…h#158590)

Summary:

Small change to make the `times` and `repeat` variables controllable as command line args.

Test Plan:
Execute:
```
buck2 run <run params> <path>:inductor_benchmark -- --times=1 --repeat=1 
```
Only runs once, and without passing the args it runs with default values of 10.

Rollback Plan:

Reviewed By: malfet

Differential Revision: D78458680
@A-Kokolis @facebook-github-bot
[inductor] Make times and repeat parameters command line args (pytorc…
d640598 
…h#158590)

Summary:
Pull Request resolved: pytorch#158590

Small change to make the `times` and `repeat` variables controllable as command line args.

Test Plan:
Execute:
```
buck2 run <run params> <path>:inductor_benchmark -- --times=1 --repeat=1
```
Only runs once, and without passing the args it runs with default values of 10.

Rollback Plan:

Reviewed By: malfet

Differential Revision: D78458680
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78458680

@A-Kokolis A-Kokolis self-assigned this Jul 17, 2025
@A-Kokolis A-Kokolis added the topic: not user facing topic category label Jul 17, 2025
FindHao
FindHao approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2025
@A-Kokolis
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@FindHao FindHao FindHao approved these changes

@yf225 yf225 Awaiting requested review from yf225

@shunting314 shunting314 Awaiting requested review from shunting314

Assignees

@A-Kokolis A-Kokolis

Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@A-Kokolis @facebook-github-bot @pytorchmergebot @malfet @FindHao
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy