Skip to content

Setup TorchBench in Docker #158613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Setup TorchBench in Docker #158613

wants to merge 26 commits into from
+38 −45

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jul 18, 2025 •
edited
Loading

This reduces the time spending to setup TorchBench in A100/H100 by another half an hour

Testing

Signed-off-by: Huy Do huydhn@gmail.com

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

huydhn added 8 commits July 17, 2025 15:51
@huydhn
Update
0e37fc8 
[ghstack-poisoned]
@huydhn
Update
ec8fa3c 
[ghstack-poisoned]
@huydhn
Update
3aec24e 
[ghstack-poisoned]
@huydhn
Update
30c21cb 
[ghstack-poisoned]
@huydhn
Update
444df0f 
[ghstack-poisoned]
@huydhn
Update
55316ba 
[ghstack-poisoned]
@huydhn
Update
a151d80 
[ghstack-poisoned]
@huydhn
Update
0ce8369 
[ghstack-poisoned]
@huydhn
Copy link
Contributor Author

huydhn commented Jul 18, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@huydhn huydhn requested review from a team and jeffdaily as code owners July 18, 2025 00:21
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158613

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 51 Pending

As of commit 9867f10 with merge base d36afac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

huydhn added a commit that referenced this pull request Jul 18, 2025
@huydhn
Setup TorchBench in Docker
14cdfdb 
This reduces the time spending to setup TorchBench in A100/H100 by half
an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: 7425aa2
ghstack-comment-id: 3086043340
Pull-Request: #158613
This was referenced Jul 18, 2025
Closed
Closed
Closed
Closed
@huydhn
Update
9fe4955 
[ghstack-poisoned]
@huydhn huydhn added the no-runner-experiments Bypass Meta/LF runner determinator label Jul 18, 2025
huydhn added a commit that referenced this pull request Jul 18, 2025
@huydhn
Setup TorchBench in Docker
fbfd790 
This reduces the time spending to setup TorchBench in A100/H100 by half
an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: 9eaa733
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn added 3 commits July 17, 2025 18:14
@huydhn
Update
9ff8af5 
[ghstack-poisoned]
@huydhn
Update
753fe8c 
[ghstack-poisoned]
@huydhn
Update
2435a78 
[ghstack-poisoned]
huydhn added a commit that referenced this pull request Jul 18, 2025
@huydhn
Setup TorchBench in Docker
663a5cc 
This reduces the time spending to setup TorchBench in A100/H100 by half
an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: 536ab13
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Update
2bc4a7d 
[ghstack-poisoned]
huydhn added a commit that referenced this pull request Jul 18, 2025
@huydhn
Setup TorchBench in Docker
a257f61 
This reduces the time spending to setup TorchBench in A100/H100 by
another half an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: c3c6d5b
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Update
14a38c7 
[ghstack-poisoned]
huydhn added a commit that referenced this pull request Jul 19, 2025
@huydhn
Setup TorchBench in Docker
9b57470 
This reduces the time spending to setup TorchBench in A100/H100 by
another half an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: a62f08f
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn added 2 commits July 19, 2025 10:48
@huydhn
Update
1d30995 
[ghstack-poisoned]
@huydhn
Update
e6bd515 
[ghstack-poisoned]
huydhn added a commit that referenced this pull request Jul 19, 2025
@huydhn
Setup TorchBench in Docker
9171a90 
This reduces the time spending to setup TorchBench in A100/H100 by
another half an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: 7374439
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Update
701a480 
[ghstack-poisoned]
@huydhn huydhn requested review from albanD and janeyx99 as code owners July 19, 2025 22:10
huydhn added a commit that referenced this pull request Jul 19, 2025
@huydhn
Setup TorchBench in Docker
e0088e6 
This reduces the time spending to setup TorchBench in A100/H100 by
another half an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: 3f0c8b5
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn changed the base branch from gh/huydhn/5/head to main July 19, 2025 22:10
@huydhn huydhn removed request for albanD and janeyx99 July 19, 2025 22:10
@huydhn huydhn requested a review from yangw-dev July 20, 2025 04:43
janeyx99
janeyx99 reviewed Jul 21, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects the docker images used in inductor benchmarks right? Or will this make pulling docker images across all of CI slightly slower?

janeyx99
janeyx99 approved these changes Jul 21, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving cuz this seems ok, my only question is that it does not affect anything else negatively

@huydhn
Copy link
Contributor Author

huydhn commented Jul 21, 2025

This only affects the docker images used in inductor benchmarks right? Or will this make pulling docker images across all of CI slightly slower?

Yup, the size of that benchmark image increases, but it's cached on the runner. I'm trying to confirm at the moment that the cache works correctly by re-running the benchmark to warm it up. Let me confirm that before landing this change.

@huydhn
Copy link
Contributor Author

huydhn commented Jul 21, 2025

Confirmed:

@huydhn
Update
9867f10 
[ghstack-poisoned]
huydhn added a commit that referenced this pull request Jul 21, 2025
@huydhn
Setup TorchBench in Docker
fa565ea 
This reduces the time spending to setup TorchBench in A100/H100 by
another half an hour

Signed-off-by: Huy Do <huydhn@gmail.com>
ghstack-source-id: ff22872
ghstack-comment-id: 3086043340
Pull-Request: #158613
Signed-off-by: Huy Do <huydhn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@ZainRizvi ZainRizvi Awaiting requested review from ZainRizvi

@yangw-dev yangw-dev Awaiting requested review from yangw-dev

Assignees
No one assigned
Labels
ciflow/inductor no-runner-experiments Bypass Meta/LF runner determinator oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: releng release notes category test-config/default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huydhn @yangw-dev @ZainRizvi @janeyx99
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy