Skip to content

QQ: Avoid secondary process when repairing leader record. #10193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

kjnilsson
Copy link
Contributor

Proposed Changes

Please describe the big picture of your changes here to communicate to the RabbitMQ team why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

A pull request that doesn't explain why the change was made has a much lower chance of being accepted.

If English isn't your first language, don't worry about it and try to communicate the problem you are trying to solve to the best of your abilities.
As long as we can understand the intent, it's all good.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.

@mkuratczyk mkuratczyk marked this pull request as ready for review December 27, 2023 12:28
@mkuratczyk
Copy link
Contributor

With this PR, we no longer see the erlang process growth in certain scenarios:
Screenshot 2023-12-20 at 17 19 41

@mkuratczyk mkuratczyk merged commit 10fb936 into main Dec 27, 2023
@mkuratczyk mkuratczyk deleted the qq-tick-tweaks branch December 27, 2023 12:29
michaelklishin pushed a commit that referenced this pull request Jan 31, 2024
* QQ: Avoid secondary process when repairing leader record.

* QQ: wait for projections before starting Ra cluster

If the leader selected is on a remote node and khepri_db is
enabled.

* dialyzer

* Fix dialyzer complaint

---------

Co-authored-by: Diana Parra Corbacho <diana.parra-corbacho@broadcom.com>
michaelklishin pushed a commit that referenced this pull request Feb 1, 2024
* QQ: Avoid secondary process when repairing leader record.

* QQ: wait for projections before starting Ra cluster

If the leader selected is on a remote node and khepri_db is
enabled.

* dialyzer

* Fix dialyzer complaint

---------

Co-authored-by: Diana Parra Corbacho <diana.parra-corbacho@broadcom.com>
michaelklishin pushed a commit that referenced this pull request Feb 29, 2024
* QQ: Avoid secondary process when repairing leader record.

* QQ: wait for projections before starting Ra cluster

If the leader selected is on a remote node and khepri_db is
enabled.

* dialyzer

* Fix dialyzer complaint

---------

Co-authored-by: Diana Parra Corbacho <diana.parra-corbacho@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy