Skip to content

Log TCP acceptor (Ranch) timeout and TLS [handshake-related] errors (backport #13979) #13985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 30, 2025

Proposed Changes

This PR addresses #11171

The proposed changes catch the exit signal emitted by ranch:handshake in rabbit_networking:handshake and log an error message in case the reason for shutting down the connection is other than closed.

The reason for not logging closed shutdown exit exceptions has been added as a context comment in the source.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments


This is an automatic backport of pull request #13979 done by [Mergify](https://mergify.com).

(cherry picked from commit 94d93a8)
(cherry picked from commit 3a5dc94)
@michaelklishin michaelklishin added this to the 4.1.1 milestone May 30, 2025
@michaelklishin michaelklishin merged commit 39951de into v4.1.x May 30, 2025
266 of 271 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.1.x/pr-13979 branch May 30, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy