FHC: use exception-safe versions of ets update functions #8790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoguin
reviewed
Jul 6, 2023
lhoguin
approved these changes
Jul 6, 2023
5d4c774 to
be1bde3
Compare
Otherwise, if the FHC runs into an exception because of an ETS write failure, most code paths begin failing. This may help with the condition in #8784.
Via `web_mqtt.enable_file_handle_cache`
be1bde3 to
9bd0697
Compare
|
This addresses several scenarios to the best of our current understanding without introducing any obvious regressions. Let merge it and allow the user to try out a |
|
Note that the OCI build failures are not related. |
michaelklishin
added a commit
that referenced
this pull request
Jul 9, 2023
FHC: use exception-safe versions of ets update functions (backport #8790)
michaelklishin
added a commit
that referenced
this pull request
Jul 10, 2023
{prefix}.enable_file_handle_cache => {prefix}.use_file_handle_cache
20 tasks
michaelklishin
added a commit
that referenced
this pull request
Jul 10, 2023
Naming follow-up to #8790
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
{prefix}.enable_file_handle_cache => {prefix}.use_file_handle_cache
(cherry picked from commit 71a23c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if the FHC runs into an exception because of an ETS write failure, most code paths begin failing.
This may help with the condition in #8784.