Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RayCluster Headless Worker Service Should PublishNotReadyAddresses #2375

Merged
merged 7 commits into from
Sep 12, 2024
Merged

RayCluster Headless Worker Service Should PublishNotReadyAddresses #2375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c2ee6ae
Publish node address before proxy has started for TPU initialization
ryanaoleary Sep 11, 2024
b020382
Add comment
ryanaoleary Sep 12, 2024
0e6e4dc
Remove error return
ryanaoleary Sep 12, 2024
9409056
Fix tests
ryanaoleary Sep 12, 2024
c92042b
Add test case for headless service
ryanaoleary Sep 12, 2024
f33ac15
Check PublishNotReadyAddresses
ryanaoleary Sep 12, 2024
dee6aec
Merge branch 'ray-project:master' into headless-svc-fix
ryanaoleary Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ray-operator/controllers/ray/common/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,10 @@ func BuildHeadlessServiceForRayCluster(rayCluster rayv1.RayCluster) (*corev1.Ser
Labels: labels,
},
Spec: corev1.ServiceSpec{
ryanaoleary marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For another PR, add unit tests for BuildHeadlessServiceForRayCluster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and added a test case in this PR (c92042b) since it's a fairly small change.

ClusterIP: "None",
Selector: selectorLabels,
Type: corev1.ServiceTypeClusterIP,
ClusterIP: "None",
Selector: selectorLabels,
Type: corev1.ServiceTypeClusterIP,
PublishNotReadyAddresses: true,
ryanaoleary marked this conversation as resolved.
Show resolved Hide resolved
},
}

Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy