[Serve.llm] Add test to guard against upstream StatLogger changes #53351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
|
We should proabably run this as a release test because the compute compatibility is limited on premerge. I don't think it is easy to change the hw of the premerge tests. but it's easy todo for release tests. |
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
kouroshHakha
approved these changes
May 28, 2025
chris-ray-zhang
pushed a commit
to chris-ray-zhang/ray
that referenced
this pull request
May 29, 2025
…y-project#53351) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Chris Zhang <chris@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
RayPrometheusStatLogger inherits from StatLoggerBase in vLLM. We need to make sure this code path is exercised to ensure our implementation stays compliant with vLLM's abstract base class.
This is needed until vLLM 0.9.0, when we will switch to the implementation which landed in vllm-project/vllm#17925.
Related issue number
Guard against issue #53335, close LLM-1969
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.