Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: react-native-netinfo/react-native-netinfo
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v11.1.0
Choose a base ref
...
head repository: react-native-netinfo/react-native-netinfo
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v11.1.1
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 29, 2023

  1. fix: internetReachability aborts handle cancel correctly (#700)

    InternetReachability aborts pending request by calling abort() of AbortController. According to AbortController API when abort() is called, the fetch() promise rejects with an Error of type DOMException, with name AbortError. So reject('canceled') will be ignored and checking error !== 'canceled' is useless.
    
    The right way is to use abort('canceled') to set reject reason to 'canceled' instead of DOMException.
    
    Previously because of that InternetReachability aborts previous request and calls _setIsInternetReachable(false).
    gizomo authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    0a36296 View commit details
    Browse the repository at this point in the history
  2. chore(release): 11.1.1 [skip ci]

    ## [11.1.1](v11.1.0...v11.1.1) (2023-11-29)
    
    ### Bug Fixes
    
    * internetReachability aborts handle cancel correctly ([#700](#700)) ([0a36296](0a36296))
    semantic-release-bot committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    1cd754d View commit details
    Browse the repository at this point in the history
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy