Skip to content

Open source the project #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

janhoy
Copy link

@janhoy janhoy commented May 31, 2024

Looks like you dropped the ball on this project @phuocng . And left all users, even paid users out in the dark.

Since you left the project die without an open source license, the community cannot legally take over either, but need to research other options or worst case write a react wrapper from scratch.

Unless you plan to continue with new releases VERY SOON, fixing CVEs, upgrading to 4.x etc, please consider open sourcing the project so that the community can fork and take over. Best solution would be to also hand over the org, but second best is for you to write in README that it is discontinued and that you recommend XXXX.

This PR changes the LICENSE file to the Apache license, just as an example.

@thijslemmens
Copy link

@phuocng Would you accept a compensation to accept this PR?

@Titorat
Copy link

Titorat commented Jun 11, 2024

Hello,

I propose something: I don't think @phuocng will respond anytime soon. It's been a long time, and many projects relying on this one are vulnerable to various attacks. I believe it would be fair for someone with a license to fork the project so we can work on it collectively. If anyone knows a lawyer, they might be able to advise us on the legal implications and how to best navigate them.

I've tried reaching out to @phuocng via email without success. I contacted him to discuss maintenance and whether I should pay for the projects.

The project has been forked numerous times already, but there's no single fork that everyone agrees to work on. I think he could actually

I am not a lawyer, but in his license here: https://react-pdf-viewer.dev/license/
He mention that we may change the item and modify it and it can still keep the original license. I know there are many Donts as well but I am just trying to come up with something because this is actually a cool project that I would hate to see go to waste.

We can maybe mention in the read me of the forked project that anyone using that one should always be a paid customer. I know this way we will be working for him but at least we can keep this project going. But I am not sure if even this will legalize the project.
@thijslemmens @janhoy

@jkgenser
Copy link

jkgenser commented Jun 13, 2024

I'm working on a complete re-write from scratch. It's in very early stages but a lot of the core functionality is there. I'm actually almost done with the subset of react-pdf-viewer that I use. After which point, I will update the code base and publish it as a proper npm repo.

This project will be 100% OSS community maintained. I am looking to fill the gap of react-pdf-viewer and get people contributing to a common project instead of maintaining a fork of a commercial project.

https://github.com/jkgenser/react-pdf-headless

It builds on two existing well-maintained libraries, react-pdf and tanstack/virtual.

Here's what I need for my use case before I release 1.0:

  • Render a PDF with a Viewer
  • onPageChanged (passed in from parent)
  • renderPage (passed in from parent)
  • zoom
  • rotation
  • jumpToPage (exposed via API from child)
  • high performance page virtualization including performant user and imperative scroll (tested on a 1700 page pdf)
  • RenderPage (passed in from parent)
  • render highlights - TBD if I use the same API as react-pdf-viewer

I am not replicating react-pdf-viewer API exactly and I am going for a more headless approach. E.g. I will allow zoom to be passed in but feel that it's not necessary to maintain a visual component for zoom. Further, I'm heavily building on react-pdf and make it so that rather than re-implementing pdf-js, react-pdf can implement the lower level pdf-js and my new react-pdf-reader can focus on implementing the document viewing functionality in a mostly headless way

Please feel free to take a look at my code and copy paste if you need! However, I would even more appreciate any replies and indicate what particular parts of react-pdf-viewer you need and I can add it to my roadmap.

@coolbaluk
Copy link

They sometime update the project (like the 4.x upgrade) but no NPM releases have been cut. Would be great indeed to get a few more contributors on board.

@Yassin-Samir
Copy link

Yassin-Samir commented Jul 1, 2024

i believe @phuocng need to respond urgently as the community is suffering for 4.x npm release or else an org clone it then maintain it after acquiring the license from @phuocng or else add more contributors and drop further npm releases

@dilip-splore
Copy link

I am also interested in contributing to this tool.
if there is any community which is seeking out for the alternatives please connect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy