Added theme a11yOneLight #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 95.97% 95.97%
=======================================
Files 11 11
Lines 323 323
Branches 123 123
=======================================
Hits 310 310
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Was this unintentionally removed in the release? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:-
I was trying multiple theme's provided by library from HLJS or Prism, but no styles were following WCAG colour contrast. Apart from A11YLight and A11YDark, I couldn't find any which supports highlighting on functionsNames, variables, classNames of Java, CSharp etch
Solution:-
I have planned to create a new theme on the top of one-light theme which fixes WCAG colour contrast issue.
Sandbox link : https://codesandbox.io/p/sandbox/syntax-highlighter-theme-wcag-compatible-forked-f3j9kw?file=%2Fsrc%2Fcomponents%2FCodeblock%2FoneLightWCAG.ts%3A8%2C28