fix metadata (IMDSv2) in EBS driver #1372
Open
+102,971
−4,343,481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1371 which is important because IMDSv2 is the new security best practice and is starting to become required for compliance with SOC2 etc.
Also migrates from the deprecated and broken
dep
vendoring tool togo mod
.I have gone to great lengths to ensure that all package versions remain the same as they were under
dep
. All versions are as they used to be, except foraws-sdk-go
, which I obviously had to upgrade slightly.go mod
ignores transitive test dependencies, so there are a lot of deletions undervendor/
, but these are only deletions of packages that are unnecessary for the build, with the obvious exception ofawk-sdk-go
and its dependencies.Note that
go.mod
contains areplace
statement to force thex/sys
version to downgrade to the same version that was used underdep
, to preventgo mod tidy
from upgrading it. I don't know whygo mod tidy
wants to upgrade it, presumably some quirk of the minimum version selection algorithm when importing repos that lack ago.mod
. This is the only package where I had to resort to any such shenanigans (the otherreplace
statements were migrated from the previous setup.) It's probably pretty low risk to allow this package to upgrade, but I wanted to keep the versions completely consistent unless the maintainers of this repo would prefer otherwise.