-
Notifications
You must be signed in to change notification settings - Fork 194
Fix countinference issue #1452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix countinference issue #1452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurisilvio
reviewed
Jul 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean comparison in Python should be done with is
instead of ==
to avoid some tricky cases.
Co-authored-by: Iuri de Silvio <iuri@roboflow.com>
Co-authored-by: Iuri de Silvio <iuri@roboflow.com>
Applied your suggestions |
…oboflow/inference into fix/fix-countinference-boolean
grzegorz-roboflow
previously approved these changes
Jul 24, 2025
grzegorz-roboflow
approved these changes
Jul 24, 2025
grzegorz-roboflow
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are not sending the countinference query parameter and service secret correctly because of a logic bug. This PR fixes the issue.
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested on local and via tests in staging.
Any specific deployment considerations
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs