Skip to content

Fix countinference issue #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2025
Merged

Conversation

bigbitbus
Copy link
Contributor

Description

We are not sending the countinference query parameter and service secret correctly because of a logic bug. This PR fixes the issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested on local and via tests in staging.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

Copy link
Contributor

@iurisilvio iurisilvio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean comparison in Python should be done with is instead of == to avoid some tricky cases.

bigbitbus and others added 2 commits July 24, 2025 10:29
Co-authored-by: Iuri de Silvio <iuri@roboflow.com>
Co-authored-by: Iuri de Silvio <iuri@roboflow.com>
@bigbitbus
Copy link
Contributor Author

Boolean comparison in Python should be done with is instead of == to avoid some tricky cases.

Applied your suggestions

@grzegorz-roboflow grzegorz-roboflow merged commit c51d08c into main Jul 24, 2025
38 of 39 checks passed
@grzegorz-roboflow grzegorz-roboflow deleted the fix/fix-countinference-boolean branch July 24, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy