Checking for exercise errors #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is never actually returned (follow up to #235)
db9c955 to
1b49f8a
Compare
cpsievert
commented
Jul 21, 2020
This was referenced Jul 21, 2020
1b49f8a to
befc8b8
Compare
…ng a checker function on exercise evaluation errors, closes #356
befc8b8 to
7bac39a
Compare
cpsievert
commented
Jul 22, 2020
schloerke
reviewed
Jul 23, 2020
schloerke
approved these changes
Jul 23, 2020
schloerke
pushed a commit
that referenced
this pull request
Jul 30, 2020
* empty_results()'s html_output needs to req()-able; otherwise, a value is never actually returned (follow up to #235) * Refactor evaluate_exercise() and add exercise.error.checker for running a checker function on exercise evaluation errors, closes #356 * code review feedback * knitr fig options were actually needed * shorter tempfile pattern * docs * Provide an exercise.error.checker option * Document new exercise.error.checker option * update news
schloerke
added a commit
that referenced
this pull request
Aug 7, 2020
* master: Disable completion of R code inside quotes, closes #401 (#413) Bump version (#414) Save tutorial output to temp folder when tutorial folder does not have write permissions (#412) Throw an informative error if an exercise chunk is NULL (#411) Remove outdated exercise option Checking for exercise errors (#403)
schloerke
added a commit
that referenced
this pull request
Sep 2, 2020
* master: Add events to website (#423) Add a checker test with error as solution (#422) Fixes for learnr on external evaluator (#420) Add shinytest support (#407) Validate the ability to create an idb store (#417) Disable completion of R code inside quotes, closes #401 (#413) Bump version (#414) Save tutorial output to temp folder when tutorial folder does not have write permissions (#412) Throw an informative error if an exercise chunk is NULL (#411) Remove outdated exercise option Checking for exercise errors (#403) Add event handler system (#398) External evaluator fixes (#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356. Adds a new option
exercise.error.checkerfor customizing the feedback provided when an exercise submission results in an evaluation error (for control over feedback when parsing user code results in error, see rstudio/gradethis#123). This option must be a function that anticipates the same arguments asexercise.checkerand return a feedback object. A recommend default for this option is the newgradethis::grade_learnr_errorfunction.Testing notes
Install
remotes::install_github("rstudio/learnr")andremotes::install_github("rstudio-education/gradethis")and run the following tutorial (rmarkdown::run("test.Rmd")). Verify that enteringstop("boom")and clicking "Submit Exercise" returns in positive (green) feedback and that entering anything else results in sensible/informative negative (red) feedback.