Fix IO#reopen, add open3 missing sigs #2359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like in initialize, it can also receive an integer as mode; also, the same accepted kwargs from initialize are also accepted here
ksss
reviewed
Mar 26, 2025
| # Open3.capture2('echo', 'hello', 'world') | ||
| # # => ["hello world\n", #<Process::Status: pid 2326299 exit 0>] | ||
| # | ||
| def self.capture2: (?Hash[String, String] env, *String cmds, ?Hash[untyped, untyped] options) -> [IO, Process::Status] |
There was a problem hiding this comment.
This is a syntax error.
It seems to me that it would be better expressed in overload.
There was a problem hiding this comment.
yes, hence why I opened this PR in a broken state. I believe that this is a valid and common signature across the stdlib (i.e. options hash optionally at the end) that RBS should be able to acknowledge. I don't think that overload would express it better.
|
@ksss I'll write the tests once we address the broken behaviour for this type of signature 👍 |
apiology
reviewed
Apr 7, 2025
| @@ -143,5 +240,827 @@ module Open3 | |||
| # Open3.capture2e('echo', 'hello', 'world') | |||
| # # => ["hello world\n", #<Process::Status: pid 2371894 exit 0>] | |||
| # | |||
| def self.capture2e: (*String, ?stdin_data: String, ?binmode: boolish) -> [String, Process::Status] | |||
| def self.capture2e: (?Hash[String, String] env, *String cmds, ?Hash[untyped, untyped] options) -> [IO, Process::Status] | |||
There was a problem hiding this comment.
The capture* methods return strings, not streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO#reopenshould be able to receive the same kwargs thatIO#openreceives; also, the mode can be an integer too.Have a separate commit adding missing sigs for
open3. @soutaro this is currently a WIP, as the sigs can't be expressed fully in RBS:pipeline_wreturn an array where the first element is stdin/stdout (IO) and the rest is one or more wait threads. "variable size" tuples can't be expressed in RBS yet as well.