Make Kernel#lambda always return a lambda #2262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does two allocations when the input is a subclass of |
5f4d777 to
052acaf
Compare
Before this commit, when Kernel#lambda receives a Proc that is not a lambda, it retuned it without modification. This commit makes it so that in all cases, Kernel#lambda returns a Proc that is a lambda. Calling a method called lambda and having it effectively do nothing was not very intuitive.
|
It seems to have a conflict now. Could you rebase this from master? |
|
Thanks for the ping. Judging from the discussion about this proposal, I don't think this is going in. I'm also not sure if this is a good idea any more. I will close this for now and rebase this if the proposal gets accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when Kernel#lambda receives a Proc that is not a lambda,
it retuned it without modification. This commit makes it so that in all
cases, Kernel#lambda returns a Proc that is a lambda.
Calling a method called lambda and having it effectively do nothing was
not very intuitive.
Feature #15973
Bug #15620