Interpolated strings are no longer frozen with frozen-string-literal: true #3488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
commented
Aug 31, 2020
| assert_predicate(s3, :frozen?) | ||
| assert_predicate(s4, :frozen?) | ||
| assert_not_predicate(s3, :frozen?) | ||
| assert_predicate(s4, :frozen?) # should probably not be frozen, but unrealistic code |
There was a problem hiding this comment.
I couldn't find what optimizes s = "#{'foo'}" to just putobject "foo".
Ideally it should not be frozen.
OTOH, I believe nobody write such code (but rather "#{s}").
There was a problem hiding this comment.
@nobu has a fix for this: https://bugs.ruby-lang.org/issues/17104#note-20
I'm not sure if it's worth the added complexity.
24042ed to
7666cbe
Compare
jeremyevans
reviewed
Aug 31, 2020
There was a problem hiding this comment.
Looks good to me, but @ko1 should probably review the compile.c parts as my experience there is more limited.
… true * Remove freezestring instruction since this was the only usage for it. * [Feature #17104]
7666cbe to
24bf9ed
Compare
|
I was waiting for more reviews but they did not happen in 2 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
freezestringinstruction since this was the only usage for it.