Make Kernel#fork a simple delegator to Process.fork #4361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
commented
Apr 6, 2021
kernel.rb
Outdated
Comment on lines
183
to
185
| def fork(*args, **kwargs, &block) | ||
| Process.fork(*args, **kwargs, &block) | ||
| end |
There was a problem hiding this comment.
I wanted to use ... argument forwarding here, but apparently that's not possible?
making kernel.rbinc
Traceback (most recent call last):
4: from ./tool/mk_builtin_loader.rb:364:in `<main>'
3: from ./tool/mk_builtin_loader.rb:364:in `each'
2: from ./tool/mk_builtin_loader.rb:366:in `block in <main>'
1: from ./tool/mk_builtin_loader.rb:247:in `mk_builtin_header'
./tool/mk_builtin_loader.rb:247:in `compile': <compiled>:183: syntax error, unexpected ..., expecting ')' (SyntaxError)
def fork(...)
^~~
<compiled>:184: syntax error, unexpected ..., expecting ')'
Process.fork(...)
^~~
make: *** [kernel.rbinc] Error 1
There was a problem hiding this comment.
Actually I had to move it back to process.c to be able to alias it as rb_f_notimplement on Windows.
This change makes it much easier to properly decorate the fork method like in `nakayoshi_fork`.
a222d1c to
4105b03
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it much easier to properly decorate the fork method like in
nakayoshi_fork.For context I was about do a feature request for a proper
before_fork/after_forkAPI (e.g. https://bugs.ruby-lang.org/issues/5446), but ultimately I think that if it was easy and clean enough to decorate theforkmethod with a prepended module, such extra API wouldn't be needed.Right now such decorator is a bit involved because the method is available as both
Kernel.forkandProcess.fork, so doing it cleanly is quite complicated, and as a matter of fact,nakayoshi_forkdoesn't decorateProcess.fork:With
Kernel.forkbecoming a delegator, it makes it much easier and reliable.@ko1 would you be open to this change?
Also @tenderlove since you were involved in the
at_forkdiscussion, as well as in thenakayoshi_forkissues.