debug_ui/display_object: Remove collapsing header for frame list #20303
Conversation
Instead, we embed it directly in a compact way. My guess is that the original reason it was put into a CollapsingHeader is that the original frame list tanked the performance when shown, but this has been fixed by using `TableBody::rows` to only render the visible rows. This allows quick access to the frame list, which is helpful for quickly seeking to the parts of a movie we're interested in.
|
Here's a preview screenshot |
|
I'm not sure removing the collapsing header is a good move. I get that it improves UX when operating directly on the frame list, but I don't think that's a main use case overall. The main idea behind collapsing headers is that each page contains basic table-like overview and additional stuff is in collapsing headers. If you look at Now, if we remove the collapsing header in I think the collapsing header is a good compromise between ease of use and potential for future expansion. There's a lot of things going on in movie clips and a lot of ways to improve debugging them. |
Well, if we ever want to add something new to the But I don't insist on removing it, if it seems likely new things will be added. Although the problem could also be solved using tabs, where the frame list would be the default tab, and you could click other tabs to get other functionality. (Just to clarify, I'm talking about nested tabs inside the |
|
If desired, I can slightly alter this pull request to use a Example of how it would look |
repro.mp4Just a quick shameless advertisement why it's so nice to have a quickly accessible frame list for quick bug reproduction (#20326) |
Instead, we embed it directly in a compact way.
My guess is that the original reason it was put into a CollapsingHeader is that the original frame list tanked the performance when shown, but this has been fixed by using
TableBody::rowsto only render the visible rows.This allows quick access to the frame list, which is helpful for quickly seeking to the parts of a movie we're interested in.