avm2: Speed up some native calls #20328
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative (maybe simpler to implement?) could be to sort the static array, and use |
331d20c to
9fd9345
Compare
adrian17
reviewed
May 21, 2025
| // "[Ruffle(FastCall)]". Unlike the rest, it is not indexed by method id- | ||
| // instead, every item in the list is a method id. | ||
| // | ||
| // FIXME: should this be some sort of hashset? |
There was a problem hiding this comment.
If you sorted the vec before putting it in, we could use binary_search instead of iter().any() to speed up* lookups without affecting memory use at all.
Alternatively, there's always https://github.com/rust-phf/rust-phf to construct a static hashset at compile time (and thus not waste any allocations), but might be an overkill here.
(*I imagine the difference might not matter as long as we have <100 fast methods. )
added 6 commits
May 22, 2025 20:36
GetProperty and CallProperty optimization logic have been moved to their own methods
Added to methods on Class, Function, Namespace, QName, String, Vector, XML and XMLList, Graphics, SoundTransform, as well as some toplevel functions and `getTimer`.
9fd9345 to
b742a7b
Compare
… `NativeCallable` metadata to the playerglobals README
b742a7b to
5289ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to optimize some calls to native functions when
[Ruffle(FastCall)]annotation,final.For example,
Math.absruns more than twice as fast with this PR as it does on currentmaster. From my testing, in most SWFs, 5-20% of calls that would beCallMethodare nowCallNative.Box2d stats:
TODO: