-
Notifications
You must be signed in to change notification settings - Fork 829
fix(bip32): rename Xpub
and Xpriv
fields from network
to network_kind
#4611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
I think we have a weak consensus against this change, unless we need to break this structure's API for other reasons. |
Pull Request Test Coverage Report for Build 15572079372Details
💛 - Coveralls |
Yeah I thought that is what we discussed as well. |
660f872
to
b6c25c4
Compare
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
Yes, I understand that, but this will eventually get patched. Is it better to rip the band-aid now or later? |
What do you mean "this will eventually get patched"? |
It's not the plan to leave the inaccurate name forever, right? |
The bip32 module needs a total overhaul but its not high priority right now. This change can easily be made when we do that and then we don't unnecessarily break downstream until there is real benefit. |
Got it, I'll just leave this here as draft then. |
Closes #4582.
Changelog
Xpriv.network
toXpriv.network_kind
.Xpub.network
toXpub.network_kind
.Common.network
toCommon.network_kind
.Yes, it's a breaking change, but it should have been done on #2232 as well.