Skip to content

update MMU code #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

update MMU code #39

merged 1 commit into from
Jul 18, 2025
+262 −43

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Jun 23, 2025

Still needs to be tested

@robamu robamu force-pushed the update-mmu-structures branch from 44f73e9 to 4a10229 Compare July 16, 2025 13:52
@robamu
Copy link
Contributor Author

robamu commented Jul 16, 2025

I used and tested this as part of a zynq7000 ethernet implementation now.

@robamu robamu marked this pull request as ready for review July 16, 2025 13:54
@robamu robamu force-pushed the update-mmu-structures branch from 4a10229 to 53091c4 Compare July 16, 2025 13:54
@robamu robamu mentioned this pull request Jul 16, 2025
Merged
jonathanpallant
jonathanpallant reviewed Jul 16, 2025
View reviewed changes
@robamu robamu force-pushed the update-mmu-structures branch from e464ad7 to 03501fe Compare July 16, 2025 16:06
robamu
robamu commented Jul 16, 2025
View reviewed changes
jonathanpallant
jonathanpallant reviewed Jul 17, 2025
View reviewed changes
Copy link
Contributor

@jonathanpallant jonathanpallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Builder API.

We probably need some test cases though, to check that we produce the 32-bit integers we expect - just in case some later refactoring drops a field.

@robamu robamu force-pushed the update-mmu-structures branch from c35d6a4 to 030c8ab Compare July 17, 2025 18:23
jonathanpallant
jonathanpallant reviewed Jul 18, 2025
View reviewed changes
@robamu
Copy link
Contributor Author

robamu commented Jul 18, 2025

I can add test cases

@robamu robamu force-pushed the update-mmu-structures branch 2 times, most recently from 810bbdb to ef2bb46 Compare July 18, 2025 14:16
@robamu
Copy link
Contributor Author

robamu commented Jul 18, 2025

I'll also update the changelog

@robamu robamu force-pushed the update-mmu-structures branch from b69370d to eb950b8 Compare July 18, 2025 14:21
@jonathanpallant jonathanpallant added this pull request to the merge queue Jul 18, 2025
@jonathanpallant
Copy link
Contributor

Thank you!

Merged via the queue into main with commit 79dba70 Jul 18, 2025
57 checks passed
@robamu robamu deleted the update-mmu-structures branch July 18, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robamu @jonathanpallant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy