Keep radix for integer literals in generated bindings #3237
Conversation
8f8d206 to
7054e0f
Compare
|
I have now included additional testing to the PR. Regarding the 13 failing existing tests: It seems that the differences are due to bindgen now generating, as intended, Rust literals using hexadecimal representation, while the values themselves have correctly stayed the same. Should I fix the expected code accordingly? |
|
The test I added was changed to use C++14 instead of C23, as it seems that the latter is not available for clang 9.0, which IIUC is used in the CI. I have changed the expected side of the previously failing existing tests. Those changes are currently included in a separate commit in case that makes review less cumbersome. I will squash it later as instructed in the contribution guidelines. |
9064c00 to
2733cf6
Compare
|
I have made the solution a lot more robust and included further unit testing. r? @emilio |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fc8e1d6 to
91928a9
Compare
|
To mitigate possible churn and not force the feature on all users immediately, I've added an option defaulting to off as per #3236 (comment). |
a370dde to
df4cd69
Compare
Use the different radix literals for integers that were used in the original C and C++ header files, now that it is supported. The new values were confirmed by hand to be the same as the original ones - they are just represented using the Rust equivalent of the original form.
- Gate the integer literal radix retaining functionality behind option `keep_integer_radices`, defaulting to `false` for now. - Add the new `--keep-integer-radices` flag to test headers that are affected by it.
The radices of integer literals in the input code, including both C and C++, are retained in the generated bindings.
Builder(.keep_integer_radices(true)) or CLI (--keep-integer-radices) switches. For now, the default is to have the feature off.CXToken_Literaltoken and for outputting the tokens during codegen, and also as a new test header file paired with its matching expected Rust binding output.There are currently three commits, which I'll squash after review as per the contribution guidelines.
Resolves #3236.