33 Pull requests merged by 12 people

• [Perf] Optimize documentation lints **a lot** (1/2) (18% -> 10%)

  #14693 merged May 21, 2025

• Improve speed of cargo dev fmt

  #14862 merged May 21, 2025

• Make trivial-copy-size-limit consistently the size of the target pointer

  #13319 merged May 21, 2025

• Rustup

  #14860 merged May 21, 2025

• Fixes manual_slice_size_computation ICE and triggers in const context

  #14804 merged May 20, 2025

• Various macro fixes for loop lints

  #14631 merged May 20, 2025

• Make lint span smaller for needless return

  #14790 merged May 20, 2025

• Fix ICE while computing type layout

  #14837 merged May 19, 2025

• needless_match: do not pretend that return is not significant in an expression

  #14757 merged May 19, 2025

• Use interned symbols instead of strings in more places

  #14840 merged May 19, 2025

• Access items through rustc_session instead of rustc_lint_defs

  #14852 merged May 19, 2025

• cargo dev fmt: format clippy_lints_internal as well

  #14853 merged May 19, 2025

• Remove obsolete restriction in code

  #14851 merged May 19, 2025

• Add new useless_concat lint

  #13829 merged May 19, 2025

• Check if dropping an expression may have indirect side-effects

  #14594 merged May 19, 2025

• Docs: Use spaces in good first issue label

  #14844 merged May 19, 2025

• fix: unnecessary_to_owned FP when map key is a reference

  #14834 merged May 18, 2025

• Add a reason to/remove some //@no-rustfix annotations

  #14839 merged May 18, 2025

• Do not call TyCtxt::type_of() on a trait

  #14830 merged May 18, 2025

• Fixing minor typo in book

  #14835 merged May 18, 2025

• empty_struct_with_brackets: do not lint code coming from macro expansion

  #14623 merged May 17, 2025

• Misc changes

  #14702 merged May 17, 2025

• Refactor and speed up cargo dev fmt

  #14638 merged May 17, 2025

• excessive_precision: Fix false positive when exponent has leading zero

  #14824 merged May 17, 2025

• Skip inner ordering checking in presence of #[repr(…)]

  #14610 merged May 16, 2025

• Extend cargo dev rename_lint

  #14633 merged May 16, 2025

• Rewrite non_copy_const

  #13207 merged May 16, 2025

• Reenable linting on UFCS deref calls

  #14808 merged May 16, 2025

• unnecessary_wraps: do not include the whole body in the lint span

  #14777 merged May 16, 2025

• match_same_arms, ifs_same_cond: lint once per same arm/condition

  #14637 merged May 16, 2025

• comparison_chain: do not lint on 2 blocks expression

  #14811 merged May 16, 2025

• Fix false positive of useless_conversion when using .into_iter().any()

  #14800 merged May 16, 2025

• Rustup

  #14815 merged May 15, 2025

17 Pull requests opened by 12 people

• Add `manual_as_slice` lint

  #14809 opened May 15, 2025

• `needless_borrow`: do not contradict `dangerous_implicit_autorefs`

  #14810 opened May 15, 2025

• Introduce coerce_container_to_any

  #14812 opened May 15, 2025

• add lint infallible_try_from

  #14813 opened May 15, 2025

• WIP: add unnecessary_split_off lint

  #14814 opened May 15, 2025

• Create summary comment for lintcheck runs

  #14816 opened May 15, 2025

• [WIP] Trigger absurd_extreme_comparisons if Duration is less than zero

  #14817 opened May 15, 2025

• Add lint `long_variable_names`

  #14818 opened May 15, 2025

• [WIP] New lint: `matches_instead_of_eq`

  #14820 opened May 16, 2025

• Verify that versions in the changelog match the lint definitions

  #14821 opened May 16, 2025

• Test that all interned symbols are referenced in Clippy sources

  #14842 opened May 18, 2025

• Add `allow-invalid` configuration option for `disallowed_*` to the documentation

  #14845 opened May 19, 2025

• [`manual_flatten`]: Fix with nested `Some` or `Ok` pattern

  #14846 opened May 19, 2025

• Use interned symbols instead of strings in more places

  #14855 opened May 20, 2025

• Support different lintcheck CARGO_TARGET_DIR env variables

  #14859 opened May 21, 2025

• Fixes `manual_flatten` removes the useless if let

  #14861 opened May 21, 2025

• Improve the suggestion for `useless_conversion`

  #14864 opened May 21, 2025

25 Issues closed by 13 people

• Nightly Clippy crashed

  #14858 closed May 21, 2025

• Manual Slice Size Calculation with DSTs ICE

  #14802 closed May 20, 2025

• Incorrect macro handling in various loop lints

  #14630 closed May 20, 2025

• How to get `mir::Local` of a variable like `let var = ...;`

  #14854 closed May 20, 2025

• Needlessly Verbose Replacement Suggestion for `needless_return`

  #14750 closed May 20, 2025

• ICE `unexpected ambiguity: CanonicalQueryInput `

  #14822 closed May 19, 2025

• False positive `needless_match` for even simple example

  #14754 closed May 19, 2025

• Add `useless_concat`

  #13793 closed May 19, 2025

• #[warn(clippy::collapsible_if)] clippy +nightly suggest code not compatible with +stable

  #14850 closed May 19, 2025

• false positive for `no_effect_underscore_binding` when drop is implemented for a field of the assigned struct

  #14592 closed May 19, 2025

• beta 1.88, if let chain should be collapsed but not possible due to || operator.

  #14838 closed May 18, 2025

• `unnecessary_to_owned` false positive when keying `HashSet<&String>`

  #14833 closed May 18, 2025

• Multi branch extract equalty result expression in block

  #14699 closed May 18, 2025

• Have a lint against usize-to-u64 casts (or, against *all* integer casts)

  #9231 closed May 18, 2025

• Clippy failed when computing type

  #14828 closed May 18, 2025

• disallowed-types warns on "does not refer to an existing type"

  #14832 closed May 18, 2025

• How to get the owner node through a variable's `HirId`

  #14797 closed May 18, 2025

• DefId CD does not have a "type_of"

  #14831 closed May 18, 2025

• `option_if_let_else` suggests code that doesn't compile

  #14484 closed May 17, 2025

• `excessive_precision` inconsistency with exponential notation

  #6341 closed May 17, 2025

• FN in clippy::borrow_interior_mutable_const

  #12979 closed May 16, 2025

• unnecessary_wraps: Annoyingly large span

  #14773 closed May 16, 2025

• Removing @rust-nofix from match_same_arms requires lint fixes

  #13835 closed May 16, 2025

• should comparison_chain only trigger for "if x > y {} else if x <y {} else {}" ?

  #4725 closed May 16, 2025

• [False Positive] About removing a into_iter() from an ops::Range

  #14656 closed May 16, 2025

19 Issues opened by 16 people

• Lint suggestion: `duplicate_impl_blocks`

  #14867 opened May 22, 2025

• needless_borrow + explicit_auto_deref suggested fix fails to compile

  #14866 opened May 22, 2025

• Suggest `A && B` for `if A { B } else { false }`

  #14865 opened May 21, 2025

• lint suggestion: unused_macro_fragment

  #14863 opened May 21, 2025

• Failed to fix 'passing a unit value to a function'

  #14857 opened May 20, 2025

• `cloned_ref_to_slice_refs` suggestion may cause error

  #14856 opened May 20, 2025

• Suboptimal chaining of string-manipulation functions

  #14849 opened May 19, 2025

• lint idea: `useless_default_generic_parameters`

  #14848 opened May 19, 2025

• Suggestion for `useless_conversion` with `.into_iter()` could be better

  #14847 opened May 19, 2025

• Lint idea: `missing_panic_message`

  #14843 opened May 19, 2025

• Intermittent CI failures

  #14841 opened May 18, 2025

• `allow-invalid` configuration option for `disallowed_*` is missing from the documentation

  #14836 opened May 18, 2025

• incompatible_msrv doesn't respect #[cfg(version(...))]

  #14827 opened May 17, 2025

• `--fix` generates type mismatch error for `clippy::manual_find`

  #14826 opened May 17, 2025

• Disable suggestion to use if-let chains

  #14825 opened May 17, 2025

• Clippy suggestion breaks code when replacing `.last()` with `.next_back()`

  #14823 opened May 17, 2025

• Suggest `LOCALHOST`

  #14819 opened May 16, 2025

• Deny imports from (configurable) modules

  #14807 opened May 15, 2025

• Lint against passing &Box<dyn Any> to a function accepting &dyn Any

  #14806 opened May 15, 2025

58 Unresolved conversations

Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.

• New lint: `borrow_mutable_copy`

  #13984 commented on May 21, 2025 • 21 new comments

• doc_suspicious_footnotes: lint text that looks like a footnote

  #14708 commented on May 21, 2025 • 9 new comments

• Add relative_path_in_macro_definition lint (#14472) #14645

  #14648 commented on May 20, 2025 • 5 new comments

• Propose to exchange ranges only when it is safe to do so

  #14432 commented on May 21, 2025 • 4 new comments

• new lint: add `call_missing_target_feature` lint

  #13240 commented on May 21, 2025 • 2 new comments

• `missing_const_for_fn`: consider constness of instance

  #14759 commented on May 16, 2025 • 1 new comment

• `while_let_loop`: Include `let` assignment in suggestion

  #14756 commented on May 18, 2025 • 1 new comment

• New lint: `manual_is_multiple_of`

  #14292 commented on May 21, 2025 • 0 new comments

• fix: `collapsible_match` suggests ref/derefs when needed

  #14221 commented on May 16, 2025 • 0 new comments

• Extend `implicit_clone` to handle `to_string` calls

  #14177 commented on May 21, 2025 • 0 new comments

• Add lint for broken doc links

  #13696 commented on May 21, 2025 • 0 new comments

• Fix `manual_inspect` to consider mutability

  #13609 commented on May 21, 2025 • 0 new comments

• Move `large_stack_frames` to suspicious

  #13592 commented on May 21, 2025 • 0 new comments

• Add `clippy::result_as_ref_deref` lint

  #13474 commented on May 21, 2025 • 0 new comments

• Add [`manual_ilog2`] lint

  #13331 commented on May 21, 2025 • 0 new comments

• Rework `empty_with_brackets`

  #13063 commented on May 17, 2025 • 0 new comments

• Update book for backport, release and sync

  #12762 commented on May 16, 2025 • 0 new comments

• Create new lints with `#[clippy::version = "nightly"]`

  #14299 commented on May 16, 2025 • 0 new comments

• Do not suggest to use implicit `DerefMut` on `ManuallyDrop` reached through unions

  #14387 commented on May 16, 2025 • 0 new comments

• Various improvements to the `incompatible_msrv` lint

  #14433 commented on May 21, 2025 • 0 new comments

• Emit disallowed_names lint for functions

  #14601 commented on May 18, 2025 • 0 new comments

• Add `global_variables` lint

  #14657 commented on May 16, 2025 • 0 new comments

• Prepare to split `clippy_lints`

  #14684 commented on May 19, 2025 • 0 new comments

• Snippet rework

  #14724 commented on May 15, 2025 • 0 new comments

• Fix `needless_for_each` suggests wrongly when closure has no braces

  #14735 commented on May 20, 2025 • 0 new comments

• Rework `module_inception`

  #14753 commented on May 17, 2025 • 0 new comments

• add `impl-ordering-except-fn-names` config field for `arbitrary_source_item_ordering`

  #14782 commented on May 20, 2025 • 0 new comments

• new restriction lint: pointer_format

  #14792 commented on May 18, 2025 • 0 new comments

• `parsed_string_literals`: new lint

  #14794 commented on May 21, 2025 • 0 new comments

• Lint TryFrom with infalliable error type

  #2144 commented on May 15, 2025 • 0 new comments

• Using `format!` to add a prefix/suffix to `String` and then never using the original `String` again

  #14512 commented on May 15, 2025 • 0 new comments

• Lint for unused arguments starting with a _

  #3219 commented on May 15, 2025 • 0 new comments

• Lint non-expressive variable names

  #644 commented on May 15, 2025 • 0 new comments

• `bind_instead_of_map` should suggest removing `Result::and_then` call when possible

  #14801 commented on May 15, 2025 • 0 new comments

• Suggest `v.trailing_zeros() == n` over `(v & (1 << n)) != 0`

  #1195 commented on May 15, 2025 • 0 new comments

• Suggest using `==` instead of `matches!`

  #14688 commented on May 15, 2025 • 0 new comments

• Add lints against more manual integer ops where direct methods exist

  #12894 commented on May 15, 2025 • 0 new comments

• collapsible_else_if disregard platform code in else branch

  #14799 commented on May 16, 2025 • 0 new comments

• Politely mention that `Box<&T>` is almost the most useless type you can have

  #2394 commented on May 16, 2025 • 0 new comments

• Restriction Lint for static / const arrays filled with a non-zero value

  #14805 commented on May 16, 2025 • 0 new comments

• `clippy --fix -- -Dwarnings` does not fail on warnings

  #13502 commented on May 16, 2025 • 0 new comments

• unusual_byte_groupings triggers for binary literals

  #11749 commented on May 16, 2025 • 0 new comments

• [Proposal] No new features period

  #14364 commented on May 17, 2025 • 0 new comments

• `manual_flatten` doesn't follow its suggestion to remove `if let` statement leading to broken code

  #14692 commented on May 17, 2025 • 0 new comments

• False positive for only_used_in_recursion for trait implementations

  #14566 commented on May 18, 2025 • 0 new comments

• feature request: `#[feature]` awareness in MSRV-gated lints

  #14477 commented on May 18, 2025 • 0 new comments

• `absolute_paths` can trigger on code produced by a macro

  #13920 commented on May 18, 2025 • 0 new comments

• `min_ident_chars` triggers on implementation block for foreign traits

  #13396 commented on May 18, 2025 • 0 new comments

• manual_flatten interaction with nested matches could better

  #6776 commented on May 19, 2025 • 0 new comments

• use statements anywhere but top of module

  #259 commented on May 19, 2025 • 0 new comments

• cargo clippy --fix failed to correct file

  #11731 commented on May 19, 2025 • 0 new comments

• Clippy fails to compile my code but cargo check succeeds

  #11585 commented on May 19, 2025 • 0 new comments

• regression: bad fix for clippy::useless_conversion on auto-Deref conversions e.g. &&[T]

  #11572 commented on May 19, 2025 • 0 new comments

• Auto-fix for `new_without_default` ignores conditional compilation

  #14552 commented on May 19, 2025 • 0 new comments

• `std_wildcard_imports` to lint against `use std::mod::*`

  #13961 commented on May 21, 2025 • 0 new comments

• Clippy can run the wrong rustc, leading to "incompatible version of rustc" errors

  #9560 commented on May 21, 2025 • 0 new comments

• Avoid reported unsoundness for implied lifetime bounds

  #12471 commented on May 20, 2025 • 0 new comments

• Josh preparations

  #12759 commented on May 21, 2025 • 0 new comments