fix: terminal, handle newline #12342
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
f86e059 to
28d4db4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
28d4db4 to
969bfab
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
969bfab to
8837590
Compare
Signed-off-by: fufesou <linlong1266@gmail.com>
8837590 to
0eebcc5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a terminal input handling issue where Android keyboards generate \n (newline) instead of \r (carriage return) when the Enter key is pressed, causing commands to not execute properly on Windows terminals. The fix converts \n to \r when connecting from mobile/web-mobile platforms to Windows peers.
- Added logic to detect when the peer system is Windows
- Implemented newline-to-carriage-return conversion for mobile platforms connecting to Windows
- Added comprehensive comments explaining the cross-platform Enter key behavior differences
Comments suppressed due to low confidence (2)
flutter/lib/models/terminal_model.dart:40
- [nitpick] Modifying the input parameter 'data' directly can be confusing and makes the code harder to follow. Consider creating a new variable like 'processedData' to hold the converted value instead of reassigning the parameter.
data = '\r';
flutter/lib/models/terminal_model.dart:38
- [nitpick] The variable name 'isMobileOrWebMobile' is redundant and unclear. Consider renaming to 'isMobilePlatform' or 'shouldConvertNewline' to better express its purpose.
final isMobileOrWebMobile = (isMobile || (isWeb && !isWebDesktop));
Terminal connection, Android -> Windows, some keyboards generate
\nwhen the Enter button is clicked.Windows requires
\rto execute the command.Linux executes the command when it receives
\ror\n.