-
Notifications
You must be signed in to change notification settings - Fork 16
[Extension] Extract and test Compliant and Non-compliant code blocks #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hey @x0rw -- thanks for starting on this! Could I ask for your reason for choosing the 2021 edition instead of the newer 2024 edition? |
I just went with 2021 out of habit. |
Could we update to the 2024 edition then? |
Hey @x0rw -- wanted to check in to see if this is a work in progress or ready for review |
It’s still in progress. I need to write some tests for it (haven’t found the time yet) because it can easily fail and cause false alerts, I guess. |
Okay, thanks for the update. |
e5df07c
to
65a6733
Compare
Extract code blocks from .rst files and create a global Rust test file (generated.rs) to check them all together using
rustc --test --edition=2021 exts/rust-code-runner/generated.rs
under the hood.Features:
anything between
// HIDDEN START
and// HIDDEN END
will not be rendered but will still be included for compilation in the generated test file.--error-format=json output
and extract minimal error information.Tasks:
How to test:
Run:
./make.py -c --offline
it will notify you in case there is any issue in any code block,also check
exts/rust-code-runner/generated.rs
after doing so.(Not rebased yet)
Resolves #80