Skip to content

client: initial support for preshared keys #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

client: initial support for preshared keys #2524

wants to merge 7 commits into from
+496 −155

Conversation

djc
Copy link
Member

@djc djc commented Jun 26, 2025 •
edited
Loading

Early feedback welcome!

Still missing: early data support.

Based on the implementation in

cc @elagergren-spideroak

@djc djc requested review from cpu and ctz June 26, 2025 11:45
@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jun 26, 2025 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1763416 1788714 ⚠️ 25298 (1.43%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 4278323 4329199 ⚠️ 50876 (1.19%) 1.15%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3831857 3841217 ⚠️ 9360 (0.24%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4238976 4248246 ⚠️ 9270 (0.22%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto_client 1151902 1161952 10050 (0.87%) 2.22%
handshake_tickets_1.2_no_crypto_client 1239584 1249724 10140 (0.82%) 2.74%
handshake_session_id_1.3_no_crypto_client 2216462 2229662 13200 (0.60%) 3.35%
handshake_tickets_1.3_no_crypto_client 2235008 2248165 13157 (0.59%) 3.31%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 64345267 64582342 237075 (0.37%) 0.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 64569555 64803770 234215 (0.36%) 0.69%
handshake_session_id_1.2_no_crypto_server 1045011 1047951 2940 (0.28%) 2.76%
handshake_tickets_1.2_no_crypto_server 1205351 1208741 3390 (0.28%) 2.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 64284810 64457184 172374 (0.27%) 0.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 49386801 49510316 123515 (0.25%) 0.38%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4164181 4173631 9450 (0.23%) 0.50%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 48025590 48134385 108795 (0.23%) 0.43%
handshake_no_resume_1.3_no_crypto_client 111577 111342 -235 (-0.21%) 1.79%
handshake_tickets_ring_1.2_rsa_aes_client 4492301 4501661 9360 (0.21%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 9475251 9493915 18664 (0.20%) 0.97%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10459316 10478067 18751 (0.18%) 1.19%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 64555591 64442259 -113332 (-0.18%) 0.62%
handshake_session_id_1.3_no_crypto_server 2103924 2100234 -3690 (-0.18%) 3.39%
handshake_tickets_1.3_no_crypto_server 2067834 2064264 -3570 (-0.17%) 3.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 48000898 48080754 79856 (0.17%) 0.52%
handshake_no_resume_1.2_no_crypto_client 98536 98679 143 (0.15%) 0.99%
handshake_no_resume_1.2_no_crypto_server 74657 74764 107 (0.14%) 1.33%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 48178072 48114368 -63704 (-0.13%) 0.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 64578179 64658149 79970 (0.12%) 0.55%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 64590524 64664997 74473 (0.12%) 0.61%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 64672491 64739543 67052 (0.10%) 0.94%
handshake_no_resume_1.3_no_crypto_server 98109 98016 -93 (-0.09%) 1.96%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 64345049 64298694 -46355 (-0.07%) 0.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 49363358 49397029 33671 (0.07%) 0.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 48034541 48004694 -29847 (-0.06%) 0.30%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 49361149 49391815 30666 (0.06%) 0.54%
handshake_session_id_ring_1.3_rsa_chacha_client 30764928 30783692 18764 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30757951 30776703 18752 (0.06%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30856608 30875372 18764 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30849601 30868353 18752 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31077681 31096523 18842 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30761070 30779690 18620 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31149291 31168133 18842 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30852750 30871370 18620 (0.06%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31084675 31103401 18726 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31080572 31099290 18718 (0.06%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31156330 31175056 18726 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31152227 31170945 18718 (0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3744681 3746901 2220 (0.06%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4607534 4610114 2580 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 49428351 49455426 27075 (0.05%) 0.56%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4878898 4881568 2670 (0.05%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4153310 4155440 2130 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 64569872 64537916 -31956 (-0.05%) 0.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 64655267 64623606 -31661 (-0.05%) 0.68%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 49360884 49338301 -22583 (-0.05%) 0.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 49431411 49409053 -22358 (-0.05%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1761244 1761989 745 (0.04%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 9488740 9492533 3793 (0.04%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 11356612 11352240 -4372 (-0.04%) 1.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2666304 2667308 1004 (0.04%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 4276505 4278099 1594 (0.04%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2669141 2669979 838 (0.03%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 11303265 11300419 -2846 (-0.03%) 1.04%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 48144426 48134537 -9889 (-0.02%) 0.52%
transfer_no_resume_ring_1.2_rsa_aes_server 45917926 45926888 8962 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46010593 46019560 8967 (0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46003297 46012258 8961 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46013176 46022132 8956 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46124480 46133442 8962 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46176177 46185146 8969 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46176462 46185423 8961 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46186561 46195519 8958 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3113986 3113450 -536 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 64474410 64467088 -7322 (-0.01%) 0.64%
transfer_no_resume_ring_1.3_rsa_chacha_server 80238168 80247136 8968 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80249978 80258934 8956 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80245477 80254430 8953 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80356942 80365905 8963 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80356019 80364979 8960 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80367046 80376007 8961 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 64450657 64456596 5939 (0.01%) 0.56%
handshake_tickets_ring_1.3_rsa_chacha_server 32187537 32190357 2820 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32188706 32191526 2820 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32188721 32191541 2820 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32289777 32292597 2820 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32290946 32293766 2820 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32290961 32293781 2820 (0.01%) 0.20%
transfer_no_resume_1.2_no_crypto_server 104985031 104993995 8964 (0.01%) 0.20%
transfer_no_resume_1.3_no_crypto_server 105032240 105041206 8966 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 31729747 31732447 2700 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 31731202 31733902 2700 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 31731436 31734136 2700 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 31851727 31854427 2700 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 31853182 31855882 2700 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 31853416 31856116 2700 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717569 1717714 145 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3304363 3304115 -248 (-0.01%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 48135909 48132473 -3436 (-0.01%) 0.50%
handshake_no_resume_ring_1.2_rsa_aes_client 2243094 2243254 160 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1289905 1289986 81 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3303145 3302941 -204 (-0.01%) 0.34%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1291091 1291170 79 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3106306 3106460 154 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330283 2330183 -100 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2335934 2335834 -100 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58002604 58003831 1227 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57994756 57995977 1221 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58005583 58006801 1218 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92531657 92532882 1225 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92529968 92531190 1222 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92520834 92522055 1221 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7215522 7215610 88 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 10987349 10987477 128 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7213570 7213649 79 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11119251 11119330 79 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11113490 11113567 77 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34732980 34732891 -89 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34734686 34734607 -79 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58109674 58109611 -63 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58114382 58114319 -63 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58119640 58119585 -55 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57900719 57900667 -52 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58056743 58056695 -48 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92569840 92569771 -69 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92579800 92579736 -64 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92575823 92575762 -61 (-0.00%) 0.20%
transfer_no_resume_1.2_no_crypto_client 117294659 117294603 -56 (-0.00%) 0.20%
transfer_no_resume_1.3_no_crypto_client 117341855 117341803 -52 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_1.2_no_crypto 337.81 µs 352.56 µs 14.75 µs (4.37%) 6.94%
handshake_no_resume_1.3_no_crypto 84.45 µs 86.69 µs 2.24 µs (2.65%) 12.24%
handshake_tickets_1.2_no_crypto 370.56 µs 380.29 µs 9.73 µs (2.63%) 3.84%
handshake_session_id_1.3_no_crypto 643.94 µs 660.18 µs 16.23 µs (2.52%) 5.92%
handshake_no_resume_1.2_no_crypto 76.02 µs 77.88 µs 1.86 µs (2.45%) 11.12%
handshake_tickets_1.3_no_crypto 626.94 µs 639.20 µs 12.25 µs (1.95%) 8.58%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.28 ms 0.06 ms (1.19%) 6.50%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.59 ms 0.05 ms (1.12%) 7.26%
transfer_no_resume_ring_1.3_ecdsap256_aes 5.29 ms 5.35 ms 0.06 ms (1.07%) 5.27%
transfer_no_resume_ring_1.2_rsa_aes 5.72 ms 5.77 ms 0.06 ms (1.04%) 4.08%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 4.98 ms 5.03 ms 0.05 ms (0.98%) 5.95%
transfer_no_resume_ring_1.3_rsa_aes 5.79 ms 5.84 ms 0.05 ms (0.93%) 4.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 574.32 µs 579.60 µs 5.29 µs (0.92%) 3.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 576.20 µs 581.00 µs 4.80 µs (0.83%) 3.72%
transfer_no_resume_1.3_no_crypto 11.85 ms 11.75 ms -0.10 ms (-0.82%) 3.18%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.19 ms 5.23 ms 0.04 ms (0.77%) 6.84%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.01 ms (-0.74%) 8.22%
handshake_no_resume_ring_1.3_ecdsap256_aes 456.86 µs 460.01 µs 3.15 µs (0.69%) 3.26%
handshake_session_id_ring_1.2_rsa_aes 1.46 ms 1.47 ms 0.01 ms (0.59%) 1.88%
transfer_no_resume_ring_1.3_ecdsap384_aes 8.40 ms 8.44 ms 0.05 ms (0.54%) 4.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha 454.65 µs 456.54 µs 1.89 µs (0.42%) 3.21%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.86 ms 12.91 ms 0.05 ms (0.41%) 2.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 13.06 ms 0.05 ms (0.41%) 2.33%
transfer_no_resume_ring_1.3_rsa_chacha 13.35 ms 13.40 ms 0.05 ms (0.39%) 1.78%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.74 ms 0.05 ms (0.35%) 2.17%
transfer_no_resume_ring_1.3_ecdsap384_chacha 15.96 ms 16.01 ms 0.05 ms (0.31%) 2.28%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.71 ms 0.04 ms (0.31%) 2.72%
handshake_no_resume_ring_1.2_rsa_aes 940.08 µs 942.78 µs 2.71 µs (0.29%) 1.28%
handshake_session_id_ring_1.3_rsa_aes 5.92 ms 5.94 ms 0.02 ms (0.26%) 1.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 8.45 ms 8.47 ms 0.02 ms (0.25%) 2.52%
handshake_tickets_ring_1.2_rsa_aes 1.55 ms 1.55 ms 0.00 ms (0.25%) 2.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 8.41 ms 8.43 ms 0.02 ms (0.24%) 2.15%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.23 ms 1.22 ms -0.00 ms (-0.23%) 7.51%
transfer_no_resume_1.2_no_crypto 11.69 ms 11.71 ms 0.03 ms (0.23%) 1.98%
handshake_tickets_ring_1.3_rsa_aes 5.99 ms 6.00 ms 0.01 ms (0.23%) 1.07%
handshake_session_id_ring_1.3_rsa_chacha 5.89 ms 5.90 ms 0.01 ms (0.21%) 1.17%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 8.63 ms 8.65 ms 0.02 ms (0.19%) 2.22%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.58 ms 1.58 ms 0.00 ms (0.18%) 6.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 9.08 ms 9.09 ms 0.02 ms (0.18%) 2.22%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.75 ms 1.75 ms 0.00 ms (0.15%) 5.68%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.40 ms 5.41 ms 0.01 ms (0.14%) 1.32%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.49 ms 8.50 ms 0.01 ms (0.14%) 1.35%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.47 ms 5.47 ms 0.01 ms (0.14%) 1.47%
handshake_no_resume_ring_1.3_rsa_aes 947.24 µs 948.47 µs 1.23 µs (0.13%) 1.57%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.23 ms 1.23 ms -0.00 ms (-0.13%) 10.30%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.56 ms 8.57 ms 0.01 ms (0.12%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 947.36 µs 948.52 µs 1.17 µs (0.12%) 1.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 9.14 ms 9.15 ms 0.01 ms (0.12%) 1.88%
handshake_tickets_ring_1.3_rsa_chacha 5.95 ms 5.96 ms 0.01 ms (0.12%) 1.19%
handshake_session_id_ring_1.3_ecdsap384_aes 8.52 ms 8.53 ms 0.01 ms (0.09%) 1.02%
handshake_tickets_ring_1.3_ecdsap384_aes 8.59 ms 8.60 ms 0.01 ms (0.09%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.26 ms 1.26 ms -0.00 ms (-0.09%) 1.60%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.55 ms 3.55 ms 0.00 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.43 ms 5.43 ms 0.00 ms (0.08%) 1.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 9.32 ms 9.33 ms 0.01 ms (0.07%) 1.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.25 ms 1.25 ms 0.00 ms (0.07%) 1.40%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.55 ms 3.56 ms 0.00 ms (0.07%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 9.09 ms 9.09 ms 0.01 ms (0.06%) 2.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 8.60 ms 8.60 ms 0.00 ms (0.05%) 2.26%
handshake_tickets_ring_1.3_ecdsap256_aes 5.50 ms 5.50 ms 0.00 ms (0.04%) 1.34%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 9.27 ms 9.27 ms 0.00 ms (0.02%) 2.64%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 9.14 ms 9.14 ms 0.00 ms (0.01%) 3.05%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 9.30 ms 9.30 ms 0.00 ms (0.00%) 2.58%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 9.28 ms 9.28 ms -0.00 ms (-0.00%) 2.22%

Additional information

Historical results

Checkout details:

@djc djc force-pushed the psk-client branch 2 times, most recently from e21e96a to 5faf6bd Compare June 26, 2025 12:10
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 47.28682% with 136 lines in your changes missing coverage. Please review.

Project coverage is 94.72%. Comparing base (194ea36) to head (829d6c4).

Files with missing lines Patch % Lines
rustls/src/client/tls13.rs 39.84% 77 Missing ⚠️
rustls/src/crypto/mod.rs 0.00% 22 Missing ⚠️
rustls/src/msgs/handshake.rs 0.00% 15 Missing ⚠️
rustls/src/client/hs.rs 78.33% 13 Missing ⚠️
rustls/src/client/handy.rs 27.27% 8 Missing ⚠️
rustls/src/client/ech.rs 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
- Coverage   95.32%   94.72%   -0.60%     
==========================================
  Files          97       97              
  Lines       21518    21668     +150     
==========================================
+ Hits        20511    20526      +15     
- Misses       1007     1142     +135

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu Awaiting requested review from cpu

@ctz ctz Awaiting requested review from ctz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djc
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy