creating axioms for lattices #39554
Open
creating axioms for lattices #39554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit d60e631; changes) is ready! 🎉 |
5 tasks
|
+1 on doing this. Just let me know once all the doctests have been added and tests pass and I will do a proper review. |
|
for some reason, probably the heuristic algo used to name the categories, the doctests are flaky EDIT: this was the case. Now they are just failing |
|
now doctests are flaky again.. |
tscrim
reviewed
Mar 21, 2025
Comment on lines
20
to
21
| all_axioms += ("Distributive", "Semidistributive", | ||
| "CongruenceUniform", "Trim", "Stone", "Extremal") |
There was a problem hiding this comment.
The doctests might be flaky because you define a number of axioms twice in the all_axioms list.
|
I am not very satisfied : in the doctests, some implications between axioms are not used to remove the implied axiom in the name. |
361c12e to
70bf0ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as this would be a natural place to put some specific methods from #37601
📝 Checklist