Remove confusion in gap interface conversion method #39909
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Documentation preview for this PR (built with commit b7caa35; changes) is ready! 🎉 |
fchapoton
reviewed
May 24, 2025
|
|
||
| TESTS:: | ||
|
|
||
| sage: BD._gap_init_() |
There was a problem hiding this comment.
you need to copy here the optional tag and the definition of BD
There was a problem hiding this comment.
This bug is non-critical, (if I recalled correctly from the last time I work on this) there are too many code that relies on x._gap_() with no argument does the wrong thing (see the other test failures) and I just haven't gotten around to fix them yet since it sounds like a lot of work.
Maybe it's better to review the dependency (#39905) first (which is ready).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the documentation changes in the issue below for an explanation why this change is correct. Basically
_gap_must take in an interface object and return element of that object; while_libgap_must take no argument and return libgap element.Also make
IncidenceStructureinherit fromSageObject— as noted in the documentation ofSageObject, all objects visible to the user ought to inherit from it.📝 Checklist
⌛ Dependencies
#39905
Not strictly necessary, but useful to see why this change is correct.