Skip to content

feat: introduce Expressive Code for code block rendering #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 3, 2025
Merged

feat: introduce Expressive Code for code block rendering #476

merged 12 commits into from
Jun 3, 2025

Conversation

saicaca
Copy link
Owner

@saicaca saicaca commented Jun 1, 2025

Based on #330

Introduce Expressive Code for code block rendering with features such as code markers and collapsible sections.

@vercel Vercel
Copy link

vercel bot commented Jun 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuwari-yags ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2025 2:38pm

@L4Ph L4Ph self-requested a review June 1, 2025 12:27
L4Ph
L4Ph approved these changes Jun 1, 2025
View reviewed changes
@Hasenpfote
Copy link
Contributor

I had a quick question about something I noticed: the original implementation accounted for both light and dark themes by allowing two theme options — did that cause any issues?

@saicaca
Copy link
Owner Author

saicaca commented Jun 2, 2025

I had a quick question about something I noticed: the original implementation accounted for both light and dark themes by allowing two theme options — did that cause any issues?

It didn't cause issues. Making code blocks always dark is partly just my personal design preference (as is the current implementation). Additionally, since I need to make modifications to Expressive Code's styling, supporting only a dark theme simplifies the work that I can release this more quickly.

I might add an option later to enable light code blocks in light mode.

@Hasenpfote
Copy link
Contributor

I see, that makes sense. Thanks for the clarification — understood!

@saicaca saicaca changed the title feat: introduce Expressive Code feat: introduce Expressive Code for code block rendering Jun 3, 2025
@saicaca saicaca merged commit ee48c2f into main Jun 3, 2025
7 checks passed
@L4Ph L4Ph deleted the expressive-code-rebase branch June 3, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L4Ph L4Ph L4Ph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saicaca @Hasenpfote @L4Ph
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy