fix(rollup-plugin): add default modules back #5234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoso
commented
Feb 26, 2025
Comment on lines
43
to
46
| it('should be capable to resolve all the base LWC module imports', async () => { | ||
| const { warnings } = await runRollup('lwc-modules/lwc-modules.js'); | ||
| const { warnings } = await runRollup('lwc-modules/lwc-modules.js', { external: [] }); | ||
| expect(warnings).toHaveLength(0); | ||
| }); |
There was a problem hiding this comment.
This test wasn't doing its job because the base modules were configured as external, which means rollup wouldn't emit warnings that would've pointed to the regression.
Comment on lines
48
to
55
| it('should be capable of resolving all the base LWC modules using a custom resolver', async () => { | ||
| const { warnings } = await runRollup('lwc-modules/lwc-modules.js', { | ||
| external: [], | ||
| plugins: [nodeResolve()], | ||
| options: { | ||
| defaultModules: [], | ||
| }, | ||
| }); |
There was a problem hiding this comment.
I also added a test for the new defaultModules option.
wjhsf
approved these changes
Feb 26, 2025
|
/nucleus test |
wjhsf
reviewed
Feb 26, 2025
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
|
/nucleus test |
|
/nucleus ignore --reason "webruntime failing due to unrelated usage of __lwc variable" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
It reintroduces the default modules removed in #5203 , but in a way that can be opted out.
Fixes #5232
Fixes #5229
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item