Allow multiple file roots, pillar roots and states dirs as arguments to salt-call #67325
Replies: 4 comments 1 reply
-
|
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Beta Was this translation helpful? Give feedback.
-
|
Looked at the diff you linked and the changes look good. When submitting a PR, just include tests that cover the changes and a changelog entry and you should be set. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks. The next two weeks there will be no activity from my side because I’m on holiday, but I’ll finish it up right after. |
Beta Was this translation helpful? Give feedback.
-
|
any update? |
Beta Was this translation helpful? Give feedback.
-
|
We are open to contributions but otherwise this is not currently a priority. |
Beta Was this translation helpful? Give feedback.
-
Is your feature request related to a problem? Please describe.
While the master config supports multiple directories for file roots, pillar roots and states dirs,
salt-calldoes not, which makes local development harder in our use case, since we don't have fixed paths that can be defined in the minion config.Describe the solution you'd like
I'd like to be able to specify the arguments
--file-root,--pillar-rootand--states-dirmultiple times. This would be backwards compatible.Describe alternatives you've considered
The alternative would be to use the minion configuration file, which is not fit for all development environments. In our use case, we point these to a checked out git repo with multiple roots in it, and we dynamically detect the full path.
Additional context
The specific use case here is one file root of our own and multiple formulas. We'd like to be able to run our highstate with one command. I've got this working with minimal changes, and I'd like to submit a PR to resolve this issue after I've done some additional testing.
Beta Was this translation helpful? Give feedback.
All reactions