saltstack · DdangJin · Jun 27, 2025 · Jun 27, 2025 · Jun 29, 2025
@@ -0,0 +1 @@
+Fix `test mode` causing unintended execution when non-boolean values are passed.
@@ -193,7 +193,10 @@ async def __call__(
         if hasattr(mod, "__opts__"):
             if not isinstance(mod.__opts__, salt.loader.context.NamedLoaderContext):
                 if "test" in self.loader.opts:
-                    mod.__opts__["test"] = self.loader.opts["test"]
+                    if self.loader.opts["test"] is False:
+                        mod.__opts__["test"] = False
+                    else:
+                        mod.__opts__["test"] = True
                     set_test = True
         if self.loader.inject_globals:
             run_func = global_injector_decorator(self.loader.inject_globals)(run_func)

@@ -33,6 +33,9 @@ async def myasync(foo):
 
     def get_opts(key):
         return __opts__.get(key, None)
+
+    async def get_opts_async(key):
+        return __opts__.get(key, None)
     """
     with pytest.helpers.temp_file(
         "mod_a.py", directory=tmp_path, contents=mod_contents
@@ -174,3 +177,23 @@ def test_loaded_func_ensures_test_boolean(loader_dir, test_value, expected):
     loaded_fun = loader["mod_a.get_opts"]
     ret = loaded_fun("test")
     assert ret is expected
+
+
+@pytest.mark.parametrize(
+    "test_value, expected",
+    [
+        (True, True),
+        (False, False),
+        ("abc", True),
+        (123, True),
+    ],
+)
+async def test_loaded_coro_ensures_test_boolean(loader_dir, test_value, expected):
+    """
+    Coroutines loaded from LazyLoader's item lookups are LoadedCoro objects
+    """
+    opts = {"optimization_order": [0, 1, 2], "test": test_value}
+    loader = salt.loader.lazy.LazyLoader([loader_dir], opts)
+    loaded_coro = loader["mod_a.get_opts_async"]
+    ret = await loaded_coro("test")
+    assert ret is expected
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix `test mode` causing unintended execution when non-boolean values are passed.