Skip to content

Add ceph to the specialFSes to match on name for set_fstab #68203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add ceph to the specialFSes to match on name for set_fstab #68203

wants to merge 1 commit into from

Conversation

ishestakov-godaddy
Copy link

@ishestakov-godaddy ishestakov-godaddy commented Jul 21, 2025 •
edited
Loading

What does this PR do?

Add cephfs to the set of FSes that are being matched by name instead of device in set_fstab

What issues does this PR fix or reference?

It's common to have multiple cephfs'es in fstab that share the same device. Currently match_on: name must be explicitly set to correctly handle this case.

Previous Behavior

match_on: name is required to be explicitly set when adding multiple cephfs mountpoints that share the same device

New Behavior

match_on: auto default value is sufficient

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Closes #68207

@ishestakov-godaddy ishestakov-godaddy requested a review from a team as a code owner July 21, 2025 10:58
@welcome Welcome
Copy link

welcome bot commented Jul 21, 2025

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject.pdl@broadcom.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

twangboy
twangboy requested changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a changelog (requires an issue) and write a test for this.

@twangboy twangboy added needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog labels Jul 22, 2025
@twangboy twangboy added this to the Argon v3008.0 milestone Jul 22, 2025
@ishestakov-godaddy ishestakov-godaddy force-pushed the make-cephfs-special branch 2 times, most recently from 1ae3b15 to 4203cf4 Compare July 23, 2025 09:49
@ishestakov-godaddy
Copy link
Author

I added a unit test and a changelog entry

@ishestakov-godaddy
Add ceph to the specialFSes to match on name for set_fstab
ec328a3 
Add unit test for set_fstab that covers the case of specialFSes
@twangboy twangboy added test:full Run the full test suite and removed needs-testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases needs-changelog labels Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twangboy twangboy twangboy approved these changes

Assignees
No one assigned
Labels
test:full Run the full test suite
Projects
None yet
Milestone
Argon v3008.0
Development

Successfully merging this pull request may close these issues.

Treat cephfs as special in mount module
2 participants
@ishestakov-godaddy @twangboy
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy