Elide conversion of receiver, extension or inline map, trailing implicit args, in DropForMap #23416
+267
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38686ed to
14974ed
Compare
|
Handling inlined map at inlining works better. Edit: working on that. Edit: actually no, it's fine in DropForMap; at some point I just decided to lift out the reference to the binding of the receiver. |
|
The related PR because I had to read the code: "It's not bad code, it's just a style choice." |
c121bd8 to
02fa81e
Compare
|
I broke the one I didn't study the debug test yet. The test run saw the SO in community_c as well. Edit: also community_b. At least it fails very fast. Edit: Green check on test, but just missed the boat on |
e9b0078 to
8691c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23409
If
mapis added to a type by conversion, consider dropping the conversion when dropping amapcall.Similarly, it doesn't matter if the method is an extension or inline: drop the map and preserve the nominal receiver.