Skip to content

bugfix: Also save infos in semanticdb #23587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jul 22, 2025

Previously, when user changed a warning to info, we would not save it and miss information if that warning was about unused. Now, we also save infos.

scalacenter/scalafix#2269

Previously, when user changed a warning to info, we would not save it and miss information if that warning was about unused. Now, we also save infos.
@tgodzik tgodzik requested a review from tanishiking July 22, 2025 17:29
@tgodzik tgodzik changed the title bugfix: Also save infos in semannticdb bugfix: Also save infos in semanticdb Jul 23, 2025
Copy link
Member

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodzik tgodzik merged commit 00d19df into scala:main Jul 25, 2025
31 checks passed
@tgodzik tgodzik deleted the add-infos-semanticdb branch July 25, 2025 07:11
tgodzik added a commit to scala/scala3-lts that referenced this pull request Jul 26, 2025
Previously, when user changed a warning to info, we would not save it
and miss information if that warning was about unused. Now, we also save
infos.

scalacenter/scalafix#2269
[Cherry-picked 00d19df]
tgodzik added a commit to scala/scala3-lts that referenced this pull request Jul 28, 2025
Previously, when user changed a warning to info, we would not save it
and miss information if that warning was about unused. Now, we also save
infos.

scalacenter/scalafix#2269
[Cherry-picked 00d19df]
@WojciechMazur WojciechMazur added this to the 3.7.3 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy